Due to missing check for length of jQuery object when quering for #modalContent IE throws a javascript error when closing modal window and trying to access nonexisting element.
Other browsers are a bit more relaxed throwing the error.
Checking for length solves the problem which also exists in the 7.x-1.x branch where problem originally was spotted.
Problematic code:
if ( $('#modalContent')) $('#modalContent').get(0).focus();
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | jquery_object_always_true-2307025-7.patch | 711 bytes | mrjmd |
| jquery_object_always_true_whether_empty_or_not.diff | 462 bytes | chemical |
Comments
Comment #1
chemical commentedComment #3
chemical commentedChanged version to 7.x-1.x-dev due to missing PHP classes in 8.x-1.x-dev
Comment #7
mrjmd commentedRe-rolled with comment typo fix.
Comment #8
damienmckennaShort 'n sweet. RTBC.
Comment #9
mrjmd commentedComment #10
japerryI'm trusting that the IE users tested and approved this ;) committed.