Tab 'Log in' shows on 'Request new password page for logged-in users and is missing for logged-out users

I believe the tabs will not be shown by default if there is only one tab available. This is also the behavior currently in D7:

IMHO, none of tabs should be shown as proposed by @gaurav_varshney. That is the behaviour in D7 as @idebr shows and, as stated, having a single link task available will hide the tabs.

The extra tab is defined by the user.page plugin at user.links.task.yml. It has a base_route of user.page. The latter has a requirement of _user_is_logged_in: 'TRUE', at user.routing.yml, making the task available for logged in users. Having a 'Log in' link only available for logged in users is odd. In D7, there is a 'Log in' link for this page for anonymous users as seen below. This is not true for D8, but trying to achieve that might have introduced this issue.

To mimic D7's behaviour, in user.links.task.yml the user.page plugin definition should be removed and and the user.login plugin definition should be changed to:

user.login:
  route_name: user.login
  base_route: user.page
  title: 'Log in'
  weight: -10

Waiting for feedback. Tagging as Novice.

Updated the issue summary with the default template to clear the path forward.

Suggestion from #6

I think proposed solution in #8 will give us a bad name for the user and password login tab if another authentication method add pages below user/login/

For avoiding this issue and as a proposed solution for this issue I'd only change route_name in user.page in user.links.task.yml to user.login.

Patch attached with this proposed solution. (Screenshots are exactly the same as #8)

The above patch seems to be working for me.

@AkshayKalose; problem here is about integration tests. As I didn't modified the test; it fails on it. I'll try to correct this ASAP.

Patch attached, looks to be working good.

I believe the patch is fine, but it also needs to update the test case.
May be removing user.page with user.login in the file -> UserLocalTasksTest.php -> testUserLoginLocalTasks()

Test updated

Removing extra spaces :)

Looks great, thanks everyone!

Screenshot after (logged out):

Screenshot after (logged in):

Updated the issue summary to include the change to the tab 'Log in'.

Included a beta evaluation in the issue summary.

Thanks @idebr, but as our dataProvider is not returning a second parameter anymore, should we remove the second parameter in the testUserLoginLocalTasks() method and the if statement too?

@gvso - yep good spot. We can remove the subtask handling from testUserLoginLocalTasks

Thanks @alexpott. Test updated

Alright then! I added an interdiff for easier reviewing.

Thanks @idebr, I forgot to do that :)

Patch #29 works. I tested this manually, and ran phpunit for `user` group. RTBC++

Nice find and fix. Looks like Alex's feedback was addressed.

Committed and pushed to 8.0.x. Thanks!