Create link field for menu_link_content baseFieldDefinitions [#2302205]

Comment	File	Size	Author
#3	create_link_field_menu_link_content-2302205-3.patch	7.65 KB	hussainweb

Comment #1

pwolanin CreditAttribution: pwolanin commented 13 July 2014 at 13:49

Title:

Create entity link for baseFieldDefinitions

» Create link field for menu_link_content baseFieldDefinitions

Similar to the plan for shortcut, we might get more efficient entity behavior to combine route, route parameters, etc

Shouldn't be worked on until after #2301319: MenuLinkNG part5: Remove dead code; and party!

Log in or register to post comments

Comment #2

mgifford

he/him

English

CreditAttribution: mgifford commented 2 October 2014 at 15:53

Status:

Postponed

» Active

Log in or register to post comments

Comment #3

hussainweb

English

CreditAttribution: hussainweb commented 25 January 2015 at 19:18

Priority:	Normal	» Major
Status:	Active	» Needs review
Related issues:		+#2407505: [meta] Finalize the menu links (and other user-entered paths) system

File	Size
create_link_field_menu_link_content-2302205-3.patch	7.65 KB

I am just uploading my work so far for review. I will be surprised if even Drupal installation succeeds.

Also, I think this might be a critical as it is related to many other critical issues around menu/routing. I am just setting it to major now like it's parent issue.

Log in or register to post comments

Comment #4

hussainweb

English

CreditAttribution: hussainweb commented 25 January 2015 at 19:30

Okay, there are some helper methods introduced in #2235457: Use link field for shortcut entity which are useful here. We can wait for that but I will try to move this ahead anyway.

Log in or register to post comments

Comment #5

25 January 2015 at 19:40

Status:

Needs review

» Needs work

The last submitted patch, 3: create_link_field_menu_link_content-2302205-3.patch, failed testing.

Log in or register to post comments

Comment #6

pwolanin CreditAttribution: pwolanin commented 25 January 2015 at 19:54

Maybe better to wait until we have a final link field schema?

Log in or register to post comments

Comment #7

hussainweb

English

CreditAttribution: hussainweb commented 25 January 2015 at 19:57

@pwolanin: You are right. I think the only thing left in the schema is the description but I at least wanted to see what would be the effect here. After seeing the failures, it seems it is better to wait out the related issues.

Log in or register to post comments

Comment #8

27 January 2015 at 16:29

Status:

Needs work

» Needs review

hussainweb queued 3: create_link_field_menu_link_content-2302205-3.patch for re-testing.

Log in or register to post comments

Comment #9

hussainweb

English

CreditAttribution: hussainweb commented 27 January 2015 at 16:30

I am retesting this as there are some helper methods in #2235457: Use link field for shortcut entity and that patch is in. Let's see how many tests fail now and we can carry on working on this.