Problem/Motivation

We are still using old CSS class names in Drupal 8:

$ git grep -n  "element-invisible"
core/modules/views_ui/js/views-admin.js:562:      this.operator.find('label').add('div.description').addClass('element-invisible');
$ git grep -n  "element-hidden"
core/modules/ckeditor/src/Plugin/Editor/CKEditor.php:218:      '#markup' => '<div id="ckeditor-hidden" class="element-hidden"></div>',
core/modules/quickedit/js/quickedit.js:408:    var $el = $('<div id="' + id + '" class="element-hidden"></div>').appendTo('body');

element-hidden and element-invisible no longer exist in Drupal, they have been simplified, see this change notice.

Proposed resolution

Rename them:
element-hidden -> hidden
element-invisible -> visually-hidden

Remaining tasks

patch

User interface changes

none

API changes

none

Files: 
CommentFileSizeAuthor
#2 drupal8-Update-element-invisible-and-element-hidden-1.patch2.07 KBer.pushpinderrana
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 73,199 pass(es). View

Comments

scor’s picture

Issue summary: View changes
er.pushpinderrana’s picture

Status: Active » Needs review
FileSize
2.07 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 73,199 pass(es). View

Please review attached patch.

cwoky’s picture

Status: Needs review » Reviewed & tested by the community

The patch works fine.

Elijah Lynn’s picture

I reviewed this patch yesterday and it applies fine but I was having trouble finding out a way to test that the HTML output actually appeared on the pages. But logically it looks like it should work.

Elijah Lynn’s picture

In order to test for the views-admin.js you need to add a new filter, then rearrange the filters and click "Create new filter group". But, it is currently broken and doesn't work. There is an issue open to fix it here.

#2168893: Views filters groups adding and removing is broken

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Nice catch.

Committed and pushed to 8.x. Thanks!

  • webchick committed 808eb74 on 8.x
    Issue #2301953 by er.pushpinderrana | scor: Fixed Update 'element-...
mparker17’s picture

Issue tags: +a11y

Woot!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mgifford’s picture

Issue tags: -a11y +accessibility