Round 2.

Patch includes:

CommentFileSizeAuthor
#6 i18n_access.2298475-6.patch25.51 KBjamesquinton
#6 i18n_access.2298475.interdiff.txt907 bytesjamesquinton
#1 i18n_access.2298475.patch25.29 KBtobiasb

Comments

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
StatusFileSize
new i18n_access.2298475.patch25.29 KB
tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Issue summary: View changes
simon georges’s picture

simon georges commented

Should this patch apply on 7.x-1.x-dev version ?
Drush make is reporting that it cannot patch. Did you previously apply other patchs?

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented

Yes this is for the latest 7.x-1.x branch.

simon georges’s picture

simon georges commented

Never mind, I don't know why drush make is complying, a "git apply" of your patch on the -dev branch works perfectly.

jamesquinton’s picture

jamesquinton commented
StatusFileSize
new i18n_access.2298475.interdiff.txt907 bytes
new i18n_access.2298475-6.patch25.51 KB

Hi,

I'm hoping to use this module on a D7 project. Language neutral is shown in the language select list on the add node form. This is also causing the tests to fail.

Inspired by https://www.drupal.org/node/1734568, attached patch moves the unset language from i18n_access_form_node_form_alter to #after_build.

danepowell’s picture

danepowell commented
Status: Needs review » Reviewed & tested by the community

This is a huge patch that rolls up a ton of other issues (more even than listed in the ticket description). Can we please get it committed before folks open duplicate issues and it gets even bigger?

danepowell’s picture

danepowell commented
Priority: Normal » Major
SirPali’s picture

SirPali commented

If anyone could pick this issue up that would be great. This module seems to do exactly what I'm looking for a for a project, but is unusable in it's current state. It looks like this patch would fix these issues but trying to apply the patch (using TortoiseGit, might be the culprit) returns a "Fatal: Corrupt patch on line 605" error.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented

The patch can only be applied to the code cloned with Git. The Drupal packaging script adds some lines that prevent the patch from applying to the packaged release.