This module configure your drupal site to use public CDNJS libraries.

Note: This module detect js/css libraries already enabled in current drupal site, replace them with CDNJS files. If you want to add new CDNJS libraries to your drupal site, please see: CDN JS

This module also provides an option to choose local CDNJS server. For example, you should choose China server if your website visitors are mostly from China.

Supported Libraries/Modules

Project Page: CDNJS Update
Git Link: http://git.drupal.org/sandbox/fzq_tsing/2291559.git

Comments

breeze_man’s picture

breeze_man commented
Issue summary: View changes
PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxfzq_tsing2291559git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

adammitchell’s picture

adammitchell commented

Hi,

Just wanted to start by saying this is a nice concept. However I have noticed that there is already a project for CDN JS https://www.drupal.org/project/cdnjs; I wonder if this module would be better suited as part of the existing one. Nonetheless here are a few other points that I have noticed.

There are a few issues found by pareview. A lot of them are just coding styles:

http://pareview.sh/pareview/httpgitdrupalorgsandboxfzqtsing2291559git

You shouldn't really use this shorthand notation.

$js = array_keys($library['files']['js'])[0];

This was only added in PHP 5.4 and will break in older versions.

Libraries detect

You make use of the libraries detect function, but you have no dependency for libraries, and no check to see if it is already installed.

Nice if it implemented its own hook

It would be nice if this module implemented its own hook so other modules can integrate with it.

Use different functions for replacing libraries

I notice you are using separate functions for replacing each library. I wonder if it would be possible to have one settings functions where you setup the libraries you wish to replace and one function that performed the replacement.

Good start but needs some work.

Adam

PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.