CommentFileSizeAuthor
#13 fix-mailto-link-syntax-2272249-13.patch1.86 KBsanchiz
#10 fix-mailto-link-syntax-2272249-10.patch1.86 KBsanchiz
#6 fix-mailto-link-syntax-2272249-6.patch1.94 KBsanchiz
#6 interdiff-2272249-4-6.txt1.02 KBsanchiz
#4 fix-mailto-link-syntax-2272249.patch871 bytestars16

Comments

matthewv789’s picture

matthewv789 commented
Category: Feature request » Bug report
matthewv789’s picture

matthewv789 commented
Title: Doesn't support jump links/hash URLs » Doesn't support jump links/hash URLs or email addresses
Issue summary: View changes
podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Version: 7.x-1.5 » 8.x-1.x-dev

Please, fix it in 8.x branch for ability to get into 7.x as backport

tars16’s picture

tars16 commented
Issue summary: View changes
StatusFileSize
new fix-mailto-link-syntax-2272249.patch871 bytes

The mailto syntax seems to be incorrect causing mailto links to be re-written with the base_url. Removing the two forward slashes. I can't find any documentation as to why they need to exist. Examples of that link open a email client with '//' as the to address.

<a href="mailto:email@address.com">email</a>

Also added an additional check against href's that start with the '#'.

sanchiz’s picture

sanchiz commented
Status: Active » Needs review

Trigger tests.

sanchiz’s picture

sanchiz commented
StatusFileSize
new interdiff-2272249-4-6.txt1.02 KB
new fix-mailto-link-syntax-2272249-6.patch1.94 KB

Add tests.

  • podarok committed af51611 on 8.x-1.x authored by sanchiz 
    Issue #2272249 by sanchiz, tars16: Doesn't support jump links/hash URLs...
podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs review » Fixed

Thanks @sanchiz. Merged
Tagged 1.0 release.

sanchiz’s picture

sanchiz commented
Issue tags: +Needs backport to D7
sanchiz’s picture

sanchiz commented
Version: 8.x-1.x-dev » 7.x-1.x-dev
Status: Fixed » Needs review
StatusFileSize
new fix-mailto-link-syntax-2272249-10.patch1.86 KB

Drupal 7 backport.

Status: Needs review » Needs work

The last submitted patch, 10: fix-mailto-link-syntax-2272249-10.patch, failed testing.

sanchiz’s picture

sanchiz commented
Status: Needs work » Needs review

Trigger bot.

sanchiz’s picture

sanchiz commented
StatusFileSize
new fix-mailto-link-syntax-2272249-13.patch1.86 KB

Trigger bot for 7.x.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs backport to D7

#13 looks good

sanchiz’s picture

sanchiz commented
Status: Reviewed & tested by the community » Fixed

Committed.

  • sanchiz committed d6533db on 7.x-1.x 
    Issue #2272249 by sanchiz, tars16, podarok: Doesn't support jump links/...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.