The border bottom goes under the help icon, and can appear to touch it also, I think this looks a bit shabby and can be done better, i.e. either not underline the icon or create some space below the icon so it does not touch the border bottom.
At first this seems like an innocuous "move the icon to .filter-help.form-wrapper {}", however that moves the icon out of the anchor.
What I'd propose here perhaps that UX either veto this move or approve, and if veto'd then we just add a bit of neg margin to move the icon up 1 or 2 pixels and I think that will work OK.
Potentially pile other small cleanups for border bottom issues here also if they're quite minor like this one.
Comment | File | Size | Author |
---|---|---|---|
#21 | Screenshot 2014-09-29 14.40.15.jpg | 356.06 KB | LewisNyman |
#21 | Screenshot 2014-09-29 14.38.07.jpg | 325.27 KB | LewisNyman |
#20 | Screen Shot 2014-09-28 at 8.36.34 AM.png | 51.69 KB | mgifford |
#18 | Screen Shot 2014-09-28 at 13.10.26.png | 10.71 KB | BarisW |
#18 | filter-help-underline-2271327-18.patch | 897 bytes | BarisW |
Comments
Comment #1
mgiffordSo is it worth just removing it from this element?
Comment #2
Jeff Burnz CreditAttribution: Jeff Burnz commentedProbably can work removing the border, I suspect the icon indicates a link/focusable element?
Comment #3
mgiffordI don't know of any best practices about this in general, however it stands alone at the moment and isn't crowded by other content.
It would be useful to have a consistent pattern though which we can leverage in Bartik...
At the moment links are underlined other than those in the header.
Comment #4
LewisNymanYeah, the icon does look weird like this. I double checked and the help icon *is* clickable, because it's inside of the link tag, so I've modified the summary to reflect this.
I think we have two solutions:
1. Move the icon up a few pixels
2. Move the icon outside of link tag
I think I prefer 1, should we try that first?
Comment #5
emma.mariaI will create a patch for idea 1.
Comment #6
emma.mariaThis patch adds more spacing between icon and underline.
Comment #7
emma.mariaOops here is the patch ;)
Comment #8
Bojhan CreditAttribution: Bojhan commentedGreat, am I correct that here is some useless height?
Comment #9
LewisNymanComment #10
mgiffordSeven doesn't have the underline under the ? icon. I think that's a better pattern that we should be repeating.
Comment #11
LewisNyman@mgifford We don't have a choice because Bartik is using border-bottom for links instead of text underline.
Comment #12
Jeff Burnz CreditAttribution: Jeff Burnz commentedLewis, I think you misread the OP - what it meant was IF we moved the icon out of the anchor that might be a UX issue. I'm not sure why you changed it, sorry but I think you misread it and removed an important sentence alluding to the UX issue of moving the icon.
#10, you can do that sort of thing, even with border bottom, its a tad on the tricky-dicky side of things, I did not cross browser test this, but it should work pretty good even with minor adjustment. I have to admit I'm not entirely down on :after content and what gets announced etc (by screenreader software).
EDIT: removed inline-block, sorry, wrong copy/paste.
Also note: what this does (in supporting browsers) is stretch the icon as the font-size is increased, so it gets bigger, i.e. covers the 1rem square, which is how it maintains its vertical alignment even though its absolutely positioned. I kind of dreamed this up while watching telly, so take it as read I did not test this a whole lot, but I think its pretty solid. The top and or right positioning could be adjusted per theme rather than in filter.admin.css
Comment #13
Jeff Burnz CreditAttribution: Jeff Burnz commentedScreenshot of the code in #12, forgot to attach...
Comment #14
LewisNyman@Jeff Oops sorry. I discussed this with Bojhan in Austin and we both agreed it's better to keep the icon within the clickable area. That's why my preferred option was to try and shift the icon position
Comment #15
Jeff Burnz CreditAttribution: Jeff Burnz commented@Lewis, oh good you got to discuss with Bojhan, yes indeed I agree its better to keep it clickable. Good stuff.
Comment #17
mgiffordComment #18
BarisW CreditAttribution: BarisW commentedHow about this? The icon still works on hover and the underline is gone.
Comment #19
BarisW CreditAttribution: BarisW commentedComment #20
mgiffordThat looks better. The ? is click-able. Here's a view in RTL. Wish we had the string itself translated, but the icon is in the right location:
Comment #21
LewisNymanThis looks really good now, great work! I've attached screenshots from Bartik and Stark
Comment #22
alexpottCommitted 1f59908 and pushed to 8.0.x. Thanks!