Failed: DatabaseSchemaObjectDoesNotExistException: Cannot change the definition of field currency_locale_pattern.locale: field doesn't exist. in DatabaseSchema_mysql->changeField() (line 454 of /var/www/html/includes/database/mysql/schema.inc).

The only odd thing about the setup is the default language is japanese. I have tried clear cache. Deactivate and reactivate.

Still just ends in an error

I also tried to switch to english and try it also, same result.

CommentFileSizeAuthor
#4 currency_2264979_4.patch3.32 KBxano

Comments

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Postponed (maintainer needs more info)

Hi! Thanks for reporting this problem.

This looks a bit odd, because this specific database field is indeed updated, but the field has existed since the first Currency 7.x-2.x release, so something else must go wrong.

Can you please provide step-by-step instructions on how to reproduce the problem using a clean Drupal installation?

ptclabs’s picture

ptclabs commented

Install currency 1.x
Disable the module, delete the directory. and install 2.1 no problem. Update to 2.2 and it has the error. 2.1 does not give an error.

Where is the field supposed to be located so i can make sure it exists with 2.1 I am guessing it is some incompatibility from having 1.0 installed.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Ah, I understand now. I was a little confused, because your original report did not make any mention of Currency 1.

The original idea was that there is no upgrade path from Currency 1 to 2, since they are so different. You must uninstall Currency 1, then install Currency 2.

Thank you very much for reporting this problem. I will look into adding an upgrade path after all, or documentating this behavior in the very least.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Version: 7.x-2.4 » 7.x-2.x-dev
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new currency_2264979_4.patch3.32 KB

Could you review this patch? You'll need a site with 7.x-1.x installed, then replace the Currency folder with 7.x-2.x, apply the patch and run update.php.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Title: Upgrade from 2.2 resulted in an error » Add a 7.x-1.x > 7.x-2.0 upgrade path
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Could you please test the patch?

ptclabs’s picture

ptclabs commented

If I could figure out a way to remove the 2.4 I would try the patch. Right now if you uninstall the module using drupal uninstall, delete the currency folder it still shows up. This thing just will not go away and is causing all sort of problems. No there is no duplicate i ran a locate.

It just will not go away. With the folder removed it no longer tries to update though. It just constantly says it is a module, and cannot uninstall, downgrade or anything. It sucks to be stuck. It pretty much has trashed the drupal install unless i can figure out a way to get rid of it.

ptclabs’s picture

ptclabs commented

Still no way to delete this module. Applied patch. No idea if it worked or not. It now says nothing to update when running upgrade.php. It still no longer lets you have api calls though. I will make another bug report about that since I assume it is working but no idea because it does not work properly.

This REALLY needs a warning on the main page saying do not install will ruin site if upgrading from 1.x

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Let's tackle those other issues in #2276031: Does not uninstall and #2276045: API calls from 1.x not working on 2.x , okay? Once we've solved those, we'll get back to this one.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Bump. Could you please test the patch on a clean Drupal installation?

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Let's add an upgrade test.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Bump.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Bump. Please review this patch.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Issue tags: +Needs tests
jorisx’s picture

jorisx commented

Error is still there.
Please review this patch and update the module...

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Needs review » Closed (outdated)

Since no Drupal 7 versions are still supported, this can be closed.