I get the following notice and warning when saving a translation the first time with entity translation field translation on a body field:
Notice: Undefined index: fr in mee_field_widget_form_alter() (line 299 of sites/all/modules/contrib/scald/modules/fields/mee/mee.module).
Warning: Invalid argument supplied for foreach() in mee_field_widget_form_alter() (line 307 of sites/all/modules/contrib/scald/modules/fields/mee/mee.module).
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | quickfix-et-widget-form-alter-issue-2257949-5.patch | 783 bytes | nagy.balint |
| #2 | quickfix-et-widget-form-alter-issue-2257949-1.patch | 932 bytes | nagy.balint |
Comments
Comment #1
nagy.balint commentedThe issue is caused by the fact that widget_form_alter is called for all values of the field (so all filled languages) even if we only submitted the english language at this time for example. But that will result in an error as the input will only have the english values then, but mee will try with all the other languages as well and fail.
Comment #2
nagy.balint commentedHere is a patch that introduces an isset check, however im not sure if this works in all situations, for me it seems to be fine.
Comment #3
nagy.balint commentedComment #4
jcisio commentedI think we could just modify this line to add the langcode:
if (isset($form_state['input'][$context['field']['field_name']])) {It was enough when the field had only one language, but it is no longer now when there is Entity Translation.
I don't have a set up right now, could you test it?
Comment #5
nagy.balint commentedYou are right, as if the original isset is false then this will be false as well, and if the original isset is true then this is equivalent to my previous patch.
Attached the simpler patch. Seems to work as well.
Comment #7
jcisio commentedI haven't tested, but this patch could never fail! So, committed. Thanks!