Problem/Motivation

Speed up testbot and simplify tests by using the testing profile instead of the standard profile.

Steps to reproduce

Proposed resolution

Convert Drupal\node\Tests\NodeAccessBaseTableTest to use the testing profile, not the standard profile.

Remaining tasks

Update patch
Review
Commit

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

CommentFileSizeAuthor
#25 interdiff-23-25.txt968 bytesjungle
#25 2254201-25.patch1.25 KBjungle
#23 2254201-23.patch936 bytessmustgrave
#23 interdiff-19-23.txt939 bytessmustgrave
#19 2254201-19.patch1.73 KBsmustgrave
#19 interdiff-17-19.txt1.86 KBsmustgrave
#17 2254201-17.patch534 bytessmustgrave
#10 2254201-10.patch1.26 KBkostyashupenko
testperf.system-EntityFilteringThemeTest.patch1.21 KBsun
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, testperf.system-EntityFilteringThemeTest.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for Drupal Ukraine Community, GOLEMS GABB commented
Issue tags: +Needs reroll
vacho’s picture

vacho CreditAttribution: vacho at Skilld commented

Changes on /core/scripts/run-tests.sh

-$test_list = simpletest_script_get_test_list();
+$test_list = array_fill(0, 1, 'Drupal\system\Tests\Theme\EntityFilteringThemeTest');

And changes on /core/modules/system/lib/Drupal/system/Tests/Theme/EntityFilteringThemeTest.php

-  protected $profile = 'standard';
+  public static $modules = array('user', 'node', 'taxonomy', 'comment');

These only restring the list for test. I think that it is not a real enhancement on performance.

BTW the file EntityFilteringThemeTest.php now is at /core/modules/system/tests/src/Functional/Theme/EntityFilteringThemeTest.php

kostyashupenko’s picture

kostyashupenko
Primary language Russian
Location Omsk
CreditAttribution: kostyashupenko at Skilld commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
2254201-10.patch1.26 KB

Status: Needs review » Needs work

The last submitted patch, 10: 2254201-10.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Version: 9.3.x-dev » 10.0.x-dev
Issue summary: View changes
Parent issue: #1595028: Convert tests using Standard profile to use Testing profile instead » #3270566: [meta] Convert remaining tests using Standard profile to use Testing profile instead
Related issues: +#1595028: Convert tests using Standard profile to use Testing profile instead

Adding issue summary and re-parenting.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs work » Needs review
FileSize
2254201-17.patch534 bytes

This may fail but we will see.

Status: Needs review » Needs work

The last submitted patch, 17: 2254201-17.patch, failed testing. View results

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs work » Needs review
FileSize
interdiff-17-19.txt1.86 KB
2254201-19.patch1.73 KB

Ignore #17 completely wrong patch.

Status: Needs review » Needs work

The last submitted patch, 19: 2254201-19.patch, failed testing. View results

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs work » Needs review

Not sure why it said it failed.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented 
+  protected static $modules = ['olivero_test', 'block'];

Installing olivero_test because it ships with an article content type with body, comment, tags, and image field, teaser view mode, etc which were being tested here.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Version: 10.0.x-dev » 10.1.x-dev
FileSize
interdiff-19-23.txt939 bytes
2254201-23.patch936 bytes

Updated patch for 10.1.x

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Needs work

Should move away from olivero_test and create what we need.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Needs work » Needs review
Issue tags: +Needs Review Queue Initiative
FileSize
2254201-25.patch1.25 KB
interdiff-23-25.txt968 bytes
smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Needs review » Reviewed & tested by the community

Changes look good!

  • catch committed 8c9110da on 10.1.x 
    Issue #2254201 by smustgrave, jungle, kostyashupenko: Fix test...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 8c9110d and pushed to 10.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.