Deadlock Fix: Only update workbench_moderation_node_history in workbench_moderation_moderate on node update [#2252871]

Trying to track down a deadlock and noticed that workbench does an update on insert, and might as well not do that (likely doesn't cause the deadlock, which is on workbench_moderation_node_history, but might as well eliminate the possibility).

To reproduce
1) Set up workbench moderation
2) Create a draft
Actual: db_update issue before any records for that nid inserted
Desired: db_update only on update

Comment	File	Size	Author
#6	2252871-workbench_moderation-db_update-6.patch	1.27 KB	alansaviolobo
#6	7.x-3.x: PHP 5.3 & MySQL 5.5, D7 CI error PHP 5.6 & MySQL 5.5, D7 CI error
#5	2252871-workbench_moderation-db_update-5.patch	1.59 KB	tracker2k
#5	7.x-1.x: PHP 5.5 & MySQL 5.5, D7 11 pass PHP 5.6 & MySQL 5.5, D7 11 pass
#1	2252871-workbench_moderation-db_update-1.patch	1.58 KB	hefox
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

hefox CreditAttribution: hefox commented 28 April 2014 at 16:57

Status:

Active

» Needs review

File	Size
2252871-workbench_moderation-db_update-1.patch	1.58 KB

Patch against stable, but code in dev looks same so hopefully applies to -dev also

Comment #2

hefox CreditAttribution: hefox commented 28 April 2014 at 19:34

Actually, this patch may fix the deadlock -- see this blog for that update on empty rows followed by insert can deadlock.

Comment #3

hefox CreditAttribution: hefox commented 28 April 2014 at 21:17

Title:

Only update workbench_moderation_node_history in workbench_moderation_moderate on node update

» Deadlock Fix: Only update workbench_moderation_node_history in workbench_moderation_moderate on node update

Reproduced it via command line

T1: UPDATE workbench_moderation_node_history set published = 0 where nid = 4701;

T2: UPDATE workbench_moderation_node_history set published = 0 where nid = 4711;

T1: INSERT INTO workbench_moderation_node_history (vid, nid, from_state, state, uid, stamp, published, current) VALUES ('8031', '4701', 'draft', 'published', '1', '1398368911', '1', '1')

T2: INSERT INTO workbench_moderation_node_history (vid, nid, from_state, state, uid, stamp, published, current) VALUES ('8031', '4711', 'draft', 'published', '1', '1398368911', '1', '1')

Where t1 and t2 are separate transactions. The last statements results in a deadlock.

Comment #4

beeradb CreditAttribution: beeradb commented 7 May 2014 at 18:07

+1 from me. We were getting deadlocks in workbench_moderation_node_history during automation runs a few times a day and this patch has fixed the issue.