FieldValidationException: error when saving entity og reference fields

I tried reproducing it on OG 2.x-dev and didn't get any error message.
Considering you refer to entityreference, which entityreference version are you using ?

I can get the reported behaviour from both a select field, and a file upload field on an OG node entity that is configured with both og_field_access and editablefields.

I have a user with only an OG role of "member", which is allowed to view all fields, but only edit two of them (og_field_access). Both of these fields are configured with editablefields widgets in the pane used to display them on node-view. The "edit" button for each of these fields is correctly shown on the display.

Clicking the "edit" button in either field produces the correct behavior (either a select list, or a file upload dialog). However, when a slection is made from the select list, or an uploaded file is "saved", then I get the attached dialog window. The change is not saved.

However, if OG Strict node access permissions is unchecked and the user has edit permissions on this content type, the node entity displays with the "edit" tab available to the user. This tab brings up a display containing edit widgets for the two fields that the user has permission to change (plus the node title). These fields can be used to successfully edit the entity and change either of these fields.

Note: I am using og-7.x-2.7.

I experienced this same issue. It does not occur when using OG Reference field widget. But it does when using Basic "Select" field widget for the entity reference (main reason for this is that I just need a simple selection of an organic group). Then go and save the settings form.

I am using latest dev version of both OG and Entity Reference.

I found a fix. Based on the entityreference_field_validate() function. We are not checking if the target_id is NULL so it causes this error to be thrown if no default value is specified. The attached patch should fix this issue.

-Jesse

Correct status.
Any chance you can add a simpleTest?

I can give it a shot when I got a moment. I have never done this before.

-Jesse

> I have never done this before.

Cool. Don't worry, we are here to guide you :)

The patch from #4 corrected the FieldValidationException for me on OG 7.x-2.7. Thanks!

I am sorry, I have been unable to find the time to build this test case. I am not sure if I will be able to find the time before drupalcon.

Ok here it is. Let me know.

-Jesse

Switching it back, thought it had to be on needs review to run the test of the patch.

Since tests don't pass, there is still work to do.

Umm... The Test that "Failed" shows that without the patch the Current state of the module fails the test. The test that passes shows that with the patch from #4 the test passes... Please test the patch.

I followed the instructions on how to create a core test case and applied it to the module, If your un-familiar with this you can see how this is done at: https://drupal.org/contributor-tasks/write-tests

#11-#13 explain this in detail.

-Jesse

I think you need to add the tests into the patch, leaving just one patch file. This way the tests and patch will be together when testing.

I followed core documentation, #10 is still a valid and tested patch.

Confirming, this fixed the issue for me, when using the latest version of OG shipped with Commons 7.x-3.13.

Confirmed. https://www.drupal.org/node/2249261#comment-8865219
entityreference_fields_do_not_validate-2249261-10.patch

Confirmed #10 patch works. Thanks!

I am also receiving this error when I try and save the og_group_ref field on the manage fields tab.

This seems like major bug, since it stops the user from changing any field settings for OG. Can we get this rolled into the 7,2 branch? Patching may work, but many site admins only stick with stable releases (like me).

Thank you.

#10 works for me as well. Tests are passing now as well. Commit it baby!

For those just joining, the patch in #10 resolves a validation error when saving field settings of an entity reference field which uses Organic Groups entity selection mode but does not use the OG Reference widget.

Sorry for waiting so long until the commit. Anyway, merged! :)

Thank you!