Add missing type hinting in doc blocks

Argh, this is probably going to clash with the work I'm doing at #2202969: clean up flag() and its low-level helpers. I'd rather postpone it until that's in.

Yup. It'll need a reroll, sorry!

Thanks for rerolling. There's a few mistakes in the patch, however:

1. +++ b/flag.api.php
   @@ -238,14 +238,14 @@ function hook_flag_access($flag, $entity_id, $action, $account) {
   + * @param int $entity_ids
   

   This is an array.

2. +++ b/flag.module
   @@ -59,12 +59,12 @@ function flag_entity_info() {
   - * @return
   + * @return DrupalEntityControllerInterface
   

   This doesn't look right.

3. +++ b/flag.module
   @@ -515,7 +515,7 @@ function flag_hook_info() {
   - * @param $entity_type
   + * @param string|NULL $entity_type
   

   Do we need to say NULL for an optional parameter? Isn't that implicit by it being optional?

4. +++ b/flag_actions.module
   @@ -136,17 +136,17 @@ function flag_actions_get_actions($flag_name = NULL, $reset = FALSE) {
   - * @param $fid
   + * @param flag_flag $fid
   

   It's an integer not an object.

5. +++ b/flag_actions.module
   @@ -136,17 +136,17 @@ function flag_actions_get_actions($flag_name = NULL, $reset = FALSE) {
   - * @param $callback
   + * @param string $callback
   

   Callable? Though I don't know if this actually takes a full PHP callable -- would need to check the function code.

6. +++ b/flag_actions.module
   @@ -165,15 +165,15 @@ function flag_actions_insert_action($fid, $event, $threshold, $repeat_threshold,
   - * @param $aid
   + * @param flag_flag $aid
   

   This doesn't look right.

7. +++ b/includes/flag/flag_flag.inc
   @@ -461,16 +461,16 @@ class flag_flag {
   -   * @param $account
   +   * @param string|NULL $account
       *   The user on whose behalf to test the flagging action. Leave NULL for the
   

   This is a user account object, not a string.

8. +++ b/includes/flag/flag_flag.inc
   @@ -530,14 +530,14 @@ class flag_flag {
   -   * @param $account
   +   * @param string|NULL $account
   

   Same here: user account entity.

Committed, with a minor reroll where a couple of hunks failed.

Thanks, and sorry it's taken me ages to get back to this!