Currently codesniffer throws a lot of errors/warnings on flag module. Let us consider cleaning up the code to remove these warnings as much as possible so as to make this module pass Coder review.

I'll be happy to work on this if someone gives me heads up that this is indeed required.

Different tasks under this meta-issue:

Fix coding standards

Missing function doc comment

Add missing type hinting in doc blocks

Comments

joachim’s picture

joachim CreditAttribution: joachim commented

Coder throws out some false positives, and things that shouldn't be fixed.

I've just run it on Flag myself, and I'm not getting that many. Feel free to make a patch, but I would suggest you segregate different kinds of warnings. E.g. do a patch for all the commenting and docs things first.

cs_shadow’s picture

cs_shadow CreditAttribution: cs_shadow commented
Title: Make flag module pass coder review » [meta] Make flag module pass coder review
Issue summary: View changes
Related issues: +#2245601: Fix coding standards, +#2245607: Missing function doc comment, +#2245609: Add missing type hinting in doc blocks