Problem/Motivation

While doing some D8 migration testing #2233883: Link migration needs to convert source url into the appropriate route format for storage, an issue was found that may be partly caused by the Link module not properly handling having no options (URL fragment, query, and attributes) when programmatically saved.

Proposed resolution

Fix core to allow saving programmatically when the options are null.
( Do not rely on the loading and saving the form, which forces a call to /Drupal/Link/Plugin/Field/FieldWidget/LinkWidget massageFormValues() )

Remaining tasks

User interface changes

No.

API changes

No.

CommentFileSizeAuthor
#1 linkitemtestnooptions-2242779-1.patch4.5 KBultimike

Comments

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented
Related issues: +#2233883: Link migration needs to convert source url into the appropriate route format for storage
StatusFileSize
new linkitemtestnooptions-2242779-1.patch4.5 KB
yesct’s picture

yesct commented
Status: Active » Needs review

sending to testbot to see what it says.

yesct’s picture

yesct commented
Issue summary: View changes

Putting issue summary template in summary. using [#NNNNN] to link issues.

Moving narrative here from the issue summary:
@ultimike

I started with the LinkItemTest and removed (commented out, for now) all the "options" stuff. Running this new test results in zero failures.

I _think_ I need to expand the test a little bit past $entity->save(), as I think the issue occurs when a link entity doesn't have any options and is rendered (see #2233883-3: Link migration needs to convert source url into the appropriate route format for storage).

I also _think_ that the current Link tests that involve saving and displaying links all pass because (as far as I can tell) they all use drupalPostForm(), which calls the Link module's massageFormValues() function which handles the case where a link has no options #2233883-4: Link migration needs to convert source url into the appropriate route format for storage).

My progress on the new test (so far) is attached as a patch. Guidance on what needs to be added to it to render and test the option-less link is more than welcome!

yesct’s picture

yesct commented
Title: Link Module - optionless link test » Link Module - Add an optionless link test
Issue tags: +Needs tests

tagging for needs tests.

Also, if we have any examples in core of programmatically saving a node with a link without options, linking to it here would be most helpful.

amateescu’s picture

amateescu commented

I think this should be fixed by the patch in #2235457: Use link field for shortcut entity.

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented

After chatting on IRC with timplunkett, I'm going to go ahead an apply the patch that amateescu referred to in comment 5 and see if that solves/helps the problem.

-mike

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented

Yep, this patch solves the D6->D8 migration issue I've been hitting (https://drupal.org/comment/8663303#comment-8663303)!

Thanks,
-mike

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented

Still waiting for https://drupal.org/node/2235457 to be committed to core...

-mike

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

The proposed solution, #2235457: Use link field for shortcut entity no longer applies, and cannot be re-rolled for PSR-4.

I tried to re-roll this patch for PSR-4. The result was an error "Fatal error: Unsupported operand types in /var/www/drupal/core/lib/Drupal/Core/Routing/UrlGenerator.php on line 242". Same result as the other patch.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs work » Postponed (maintainer needs more info)
Issue tags: +stale-issue-cleanup

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

smustgrave’s picture

smustgrave commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Since it's been 3+ months without a follow up I think it's safe to close this one. If still needed for D11 please reopen!

Thanks all