[Meta] Fix ConfigurableLanguageManager getLanguages()

So we can see what we are talking about.

  /**
   * {@inheritdoc}
   */
  public function getLanguages($flags = Language::STATE_CONFIGURABLE) {
    if (!isset($this->languages)) {
      // Prepopulate the language list with the default language to keep things
      // working even if we have no configuration.
      $default = $this->getDefaultLanguage();
      $this->languages = array($default->id => $default);

      // Retrieve the config storage to list available languages.
      $prefix = 'language.entity.';
      $config_ids = $this->configFactory->listAll($prefix);

      // Instantiate languages from config objects.
      $weight = 0;
      foreach ($this->configFactory->loadMultiple($config_ids) as $config) {
        $data = $config->get();
        $langcode = $data['id'];
        // Initialize default property so callers have an easy reference and can
        // save the same object without data loss.
        $data['default'] = ($langcode == $default->id);
        $data['name'] = $data['label'];
        $this->languages[$langcode] = new Language($data);
        $weight = max(array($weight, $this->languages[$langcode]->weight));
      }

      // Add locked languages, they will be filtered later if needed.
      $this->languages += $this->getDefaultLockedLanguages($weight);

      // Sort the language list by weight.
      Language::sort($this->languages);
    }

    return parent::getLanguages($flags);
  }

#2228129: Unnecessary separate config load call to load languages
changed this code but didn't update the comment.

      // Retrieve the config storage to list available languages.
      $prefix = 'language.entity.';
      $config_ids = $this->configFactory->listAll($prefix);

but we dont want to get it from config anyway.
we should try and use the entity system.

let's see if this passes. (it might not work if this is called before we have a database)

foreach (\Drupal::entityManager()->getStorage('language_entity')->loadMultiple() as $language ) {

--

if this works, we can inject the entityManager later.

---------------------------
open an separate issue for:

        $data = $language->toArray();
        $langcode = $data['id'];
        // Initialize default property so callers have an easy reference and can
        // save the same object without data loss.
        $data['default'] = ($langcode == $default->id);
        $data['name'] = $data['label'];
        $this->languages[$langcode] = new Language($data);

that logic should just be in a method like getDataObject(). then we could just:

$this->languages[$langcode] = $language->getDataObject();

should the LanguageInterface when language module is installed be called ConfigurableLanguageInterface (note that that language manager is called ConfigurableLanguageManager).

------

thought about doing this:

diff --git a/core/modules/language/lib/Drupal/language/ConfigurableLanguageManager.php b/core/modules/language/lib/Drupal/language/ConfigurableLanguageManager.php
index b164cd5..8414ee9 100644
--- a/core/modules/language/lib/Drupal/language/ConfigurableLanguageManager.php
+++ b/core/modules/language/lib/Drupal/language/ConfigurableLanguageManager.php
@@ -17,7 +17,7 @@
 use Symfony\Component\HttpFoundation\Request;

 /**
- * Overrides default LanguageManager to provide configured languages.
+ * Overrides the Core LanguageManager to provide configured languages.
  */
 class ConfigurableLanguageManager extends LanguageManager implements ConfigurableLanguageManagerInterface {

=================

uploading these just to see what tests break and thought seeing it in code might help clarify thoughts on things.

=================

------
6

better type hint (should be no test fails)
changes type hint to indicate what it is an array of

-------
6b
there are two classes named LanguageInterface.
one is for the Core (language unaware language interface), one is for when language module is installed and language is a config entity.
name the language interface similar to the way that language manager is in the first case LanguageManager and in the second ConfigurableLanguageManager.

------
6c
options was really property values.
and name was not the label/name but the key (name)

@plach yep. I'm on it. making actual separate issues with specific titles and summaries.

done opening sub issues.
put the list in the summary.