Option to hide title on rendered entities implementing EntityAPIControllerInterface

@nithinkolekar, I like the idea. I also think it could be useful for other modules Entity Registration.

+++ C:/server/www/drup_dlist/sites/all/modules/entityreference/entityreference.module	Wed Apr 09 02:17:46 2014
@@ -1264,8 +1272,12 @@
+		if(!empty($settings['hide_title']))

I think there are whitespace issues with this patch.

You may try running your code through the Coder module first.

Also you have to set the status back to "Needs Work" for the automatic testing to be triggered.

@nithinkolekar

The patch failed because of

Detect invalid patch format
Ensure the patch only contains unix-style line endings.

This a common error on windows. You have to set up whichever text editor or IDE your are using to unix-style endings. It also helps if you set it up with other Drupal coding standards. A lot of the popular ones have extensions or add-ons that format files correctly for Drupal standards.

Looks like you are still getting the error

Ensure the patch only contains unix-style line endings.

Maybe leftover from when you were editing files on Windows?

Also I am not sure if you have to but if I am running Coder I usually switch the setting to "minor (most)" from normal. It will alter you of the most problems.

@nithinkolekar this time it was actually a different error

Detect a non-applicable patch
Ensure the patch applies to the tip of the chosen code-base.

See https://qa.drupal.org/pifr/test/767018

This means that our patch didn't apply to the correctly to the repo. Which version of the module were you working against? You should usually be writting patches against the dev version or in this case branch 7.x-1.x. But the issue was set to 7.x-1.1. I will change the issue and retest to see if it fixes it.

13: entityreference-hide-entityform-title-update2.patch queued for re-testing.

Is there any progress on this issue?
Thanks

Hi there,

I just applied the patch manually, it works perfect. Does the job and no errors at all for now.
I noticed a few things that could explain why the patch won't pass.
It looks like indentation is not good on this line
+ $element['hide_title'] = array(
and also for this block of code

+    if (!empty($settings['hide_title']))
+      $hide_title = TRUE;
+    else
+      $hide_title = FALSE;

but more importantly, I believe Drupal's best practice states that conditional statements should always have braquets '{}' even if one-line-only.
I have never created a patch yet so maybe this won't solve it but I would personally try that.
Good luck! Hope this gets committed in next version but just in case I'm gonna apply a display: none as a backup plan...

Re-roll for dev.

RTBC. The rationale behind the patch is straight-forward: Add a flag that controls the value of the $page parameter when calling entity_view.

$page: (optional) If set will control if the entity is rendered: if TRUE the entity will be rendered without its title, so that it can be embeded in another context. If FALSE the entity will be displayed with its title in a mode suitable for lists. If unset, the page mode will be enabled if the current path is the URI of the entity, as returned by entity_uri(). This parameter is only supported for entities which controller is a EntityAPIControllerInterface.

An addition that could be useful, is to show the setting iff the current entity controller implements EntityAPIControllerInterface.

//Josef

Added EntityAPIControllerInterface implementation guard, as settings are confusing for e.g. nodes when "Hide title" has no effect.

@nithinkolekar: You are correct that entities should be displayed as configured under their respective "Manage display" section. I don't quite follow what you cannot get working, can you provide more info / screenshots?

//Josef

Ah, I see. The display settings are how to display the form submissions, not the form itself (Similar to how you configure node display under content types). To hide the form title without this patch, I suppose the quickest way would be to override its template or theme function.

//Josef

I tried this patch with a taxonomy entity-reference and with the title module enabled. It didn't hide the title tough (talking about the title in the template file).
To me a more logical place would be the manage display tab, because thats where you configure the viewmodes.

This feature is something I've been looking for on a few separate occasions, I'm glad to finally have found it.

Patch from #25 works great with a custom entity being referenced. Not using the title module.

Would love to see this in the next release.

I tested #25 with entityforms and works as expected

Successfully applied the patch but I can't see option to hide title in a rendered entity field.
what am I doing wrong?

What kind of entities are you rendering? This patch only controls the $page flag in entity_view (See #23). The setting will only be available when referenced entities implement EntityAPIControllerInterface, entityforms being the prime use case. For other entities - nodes, taxonomy terms, users and the like - you will have to find an alternative solution.

Patch fails against latest dev.

I've re-rolled the patch. However it needs test cases before I can commit it to dev.

Re-roll against dev.