Merge obsolete CachedModuleHandler into ModuleHandler

+++ b/core/lib/Drupal/Core/Extension/ModuleHandler.php
@@ -56,6 +56,20 @@ class ModuleHandler implements ModuleHandlerInterface {
+   * Cache backend for storing enabled modules.
...
+  protected $bootstrapCache;

@@ -69,19 +83,22 @@ class ModuleHandler implements ModuleHandlerInterface {
+  public function __construct(array $module_list = array(), CacheBackendInterface $bootstrap_cache) {
...
+    $this->bootstrapCache = $bootstrap_cache;

I don't think we need to name this around the cache bin that we are passing in. As far as this object is concerned, this is just a cache bin. I don't think the name in the property is necessary.

Thanks, looks good. Let's wait for the bot. But I think this is ready.

+++ b/core/lib/Drupal/Core/Extension/ModuleHandler.php
@@ -232,17 +249,31 @@ public function loadInclude($module, $type, $name = NULL) {
+      if ($cache = $this->cacheBackend->get('hook_info')) {
...
+        $this->cacheBackend->set('hook_info', $this->hookInfo);

@@ -264,16 +294,38 @@ public function getImplementations($hook) {
+    $this->cacheBackend->set('module_implements', array());
+    $this->cacheBackend->delete('hook_info');

Did we ever considered to move this two cache entries into one? This could be a task for a followup.

+++ b/core/lib/Drupal/Core/Extension/ModuleHandler.php
@@ -264,16 +294,38 @@ public function getImplementations($hook) {
+    // $this->cacheBackend->get() is more or less constant and reduced further when
...
+    // gains when a large number of modules are installed or hooks invoked, since

@@ -450,9 +502,55 @@ public function alter($type, &$data, &$context1 = NULL, &$context2 = NULL) {
+        // It is possible that a module removed a hook implementation without the

More then 80 chars.

I was told to DIY so posting a new patch. We are already updating the docs by adding {@inheritdoc} so I went ahead and fixed 80 char limit for whole ModuleHandler.php file. I hope it is not an issue.
This is a doc change so leaving it RTBC.

Next step is to remove hook_hook_info() entirely. No longer needed with auto-loadable code.

Sorry, views still uses this... views hooks are loaded from MODULE.views.inc or MODULE.views_execution.inc files.

Great, thanks @sun!

Yes. Would be really good to get this one in!

rerolled.

24: module.handler.24.patch queued for re-testing.

Updating with reroll.

module.handler.29.patch no longer applies.

error: patch failed: core/lib/Drupal/Core/Extension/CachedModuleHandler.php:1
error: core/lib/Drupal/Core/Extension/CachedModuleHandler.php: patch does not apply

Updating patch with reroll.

Committed/pushed to 8.x, thanks!