Closed (cannot reproduce)
Project:
Drupal core
Version:
8.0.x-dev
Component:
documentation
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
23 Sep 2013 at 07:35 UTC
Updated:
1 Oct 2014 at 13:11 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jhodgdonPlus, neither one of them follows our standards for first-line class docs (should start with verb).
Comment #2
ericmaster commentedHere's a patch for this, please review to see if it needs further explanation
Comment #3
jhodgdonGreat! The only problem is that the first-line description of a class is supposed to fit in an 80-character line. Maybe it can just say "... installation, using the bootstrap cache."?
Actually, is "bootstrap cache" the right term?
Comment #4
jguille commentedHere an incremental patch which solves the last problem.
I think it is right term because it is used in the class:
Comment #5
jhodgdonI see that $bootstrapCache is the name of the class variable, but I think maybe the comment should just say "using a cache", because this cache variable is passed into the constructor. The way these things work, I don't think it's going to be specifically the "bootstrap cache" that is passed in, but just generically the Drupal cache service. Right?
Comment #6
sunI think this issue should be closed, because #2231419: Merge obsolete CachedModuleHandler into ModuleHandler
Comment #7
jhodgdonOK let's at least postpone this one until that other one is decided on.
Comment #8
mgiffordSeems decided on.
Comment #9
jhodgdonYes, but that issue made CachedModuleHandler go away, so this issue is no longer needed. There is only one class.