Use a proper kernel in early installer

Fixed last minute cleanup/optimization: theme_handler needs a Routing\MatcherDumper.

Just a hint, it uses a route builder not a matcher dumper.

... took it back ...

1. +++ b/core/includes/install.inc
   @@ -625,19 +625,16 @@ function drupal_install_system($install_state) {
   +  $kernel = new DrupalKernel('prod', drupal_classloader(), FALSE);
   

   Just wondering whether 'prod' is really the right name. Can't we keep 'install' for semantic reasons?

2. +++ b/core/lib/Drupal/Core/CoreServiceProvider.php
   @@ -86,27 +85,6 @@ public function register(ContainerBuilder $container) {
   -      // During installation we use the non-cached version.
   -      $container->register('module_handler', 'Drupal\Core\Extension\ModuleHandler')
   -        ->addArgument('%container.modules%');
   -    }
   

   So we not longer need to use the non-cached version? What was the reason before to need this?

run-tests.sh is able to operate without first having to install Drupal and enable Simpletest! :-)

.

That is awesome!

That patch is good for now

1. use Drupal\Core\CoreServiceProvider;
   use Symfony\Component\DependencyInjection\ContainerInterface;
   

   Are no longer used in install.core.inc

2. use Drupal\Core\Language\Language;
   

   Not used in InstallerServiceProvider.php

3. +++ b/core/lib/Drupal/Core/Routing/NullMatcherDumper.php
   @@ -0,0 +1,63 @@
   + * Dumps Route information into /dev/null.
   

   This is not true. It makes the dump operation not dump but it does not dump to /dev/null

4. +++ b/core/includes/install.core.inc
   @@ -1565,9 +1411,9 @@ function install_select_language(&$install_state) {
   -  if ($request_params->has('langcode')) {
   ...
   -    $langcode = $request_params->get('langcode');
   

   Can remove $request_params = \Drupal::request()->request; from install_select_language() now.

5. +++ b/core/lib/Drupal/Core/Installer/InstallerServiceProvider.php
   @@ -0,0 +1,82 @@
   +use Drupal\Core\DependencyInjection\ContainerInterface;
   

   Does not exist and is not used.

6. +++ b/core/lib/Drupal/Core/Routing/NullMatcherDumper.php
   @@ -0,0 +1,63 @@
   +   * @var Symfony\Component\Routing\RouteCollection
   

   Missing leading slash.

Nice. Less special installer code++

Committed 45e61d2 and pushed to 8.x. Thanks!

In reading this patch, I discovered an exciting @todo. In Drupal\Core\Installer\InstallerRouteBuilder there is a todo that states: "Convert installer steps into routes; add an installer.routing.yml"

Is there already a follow up issue for that?

Great news! There's so many awesome things going on with the installer that it's a challenge to stay current / find ways to help. I'll keep at eye on that issue for further information.

Will this work enable being able to hook in custom install steps? Would be kind of nice to kick off a set of Migrate tasks during install for some kinds of projects.

Sure thing. Only thing is, this is functionality we already have in D7. For example take a look at the AbleOrganizer distribution. As a part of it's final install steps it loads sample data into the site in order to demonstrate the system and its reporting capabilities.

My request is to not lose that capability while presenting a DX experience that make it easy to know how to extend the installation process with additional tasks.

And that sounds a lot like what we had with D7. It makes me wonder if I really do need to open a ticket for this. I'm just asking to keep that capability despite the changes to the underlying architecture.