Create or Review Drush command : search-api-server-clear index

CommentFileSizeAuthor
#9 2230935-8--drush_server_clear.patch1.68 KBdrunken monkey
#7 2230935-6--drush_server_clear.patch1.72 KBdrunken monkey
#7 2230935-6--drush_server_clear--interdiff.txt1.56 KBdrunken monkey
#5 add_drush_command-2230935-5.patch1.81 KBshkiper
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

m1r1k’s picture

m1r1k CreditAttribution: m1r1k commented
Status: Active » Fixed
Issue tags: +Amsterdam2014

Already implemented.

m1r1k’s picture

m1r1k CreditAttribution: m1r1k commented
Status: Fixed » Postponed (maintainer needs more info)

Sorry, INDEX-clear command was implemented.

@freblasty, what should this command implement?

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey commented
Title: Create or Review Drush command : search-api-server-clear index » Create or Review Drush command : search-api-server-clear SERVER
Status: Postponed (maintainer needs more info) » Active

I guess it should call \Drupal\search_api\Entity\Server::deleteAllItems().

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey commented
Title: Create or Review Drush command : search-api-server-clear SERVER » Create or review Drush command: search-api-server-clear
Project: Search API (8.x) » Search API
Version: » 8.x-1.x-dev
Component: Drush » Drush / Rules
shkiper’s picture

shkiper CreditAttribution: shkiper as a volunteer commented
Status: Active » Needs review
FileSize
add_drush_command-2230935-5.patch1.81 KB
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Dazzle commented
Status: Needs review » Reviewed & tested by the community

I tested this, looks great.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Reviewed & tested by the community » Needs review
FileSize
2230935-6--drush_server_clear--interdiff.txt1.56 KB
2230935-6--drush_server_clear.patch1.72 KB

Yeah, largely looks good. Just some minor documentation coding standards issues, a typo and a bit of shortening ($index->clear() already checks $index->status()).

Also, not in the interdiff (since that would have made it useless): Moved the command and method one position up, since I think it fits better there.

Also, this needed a re-roll anyways, due to #2682369: Fix problems with overridden config entities.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Dazzle commented
Status: Needs review » Reviewed & tested by the community

Let's get this in.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Reviewed & tested by the community » Needs review
FileSize
2230935-8--drush_server_clear.patch1.68 KB

Thanks for reviewing!
Could someone also manually test whether this still works as expected? Would be good to hear.

In any case, this needed a re-roll due to #2268809: Use short array syntax in module.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Dazzle commented
Status: Needs review » Reviewed & tested by the community

Works great.

  • drunken monkey committed 51a4219 on 8.x-1.x authored by shkiper 
    Issue #2230935 by shkiper, drunken monkey: Added the "search-api-server-...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Good to hear, thanks for testing!
Committed.
Thanks again, everyone!

(And … interesting tag!)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.