Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Create or Review Drush command : search-api-server-clear index
Comment | File | Size | Author |
---|---|---|---|
#9 | 2230935-8--drush_server_clear.patch | 1.68 KB | drunken monkey |
| |||
#7 | 2230935-6--drush_server_clear.patch | 1.72 KB | drunken monkey |
|
Comments
Comment #1
m1r1k CreditAttribution: m1r1k commentedAlready implemented.
Comment #2
m1r1k CreditAttribution: m1r1k commentedSorry, INDEX-clear command was implemented.
@freblasty, what should this command implement?
Comment #3
drunken monkeyI guess it should call
\Drupal\search_api\Entity\Server::deleteAllItems()
.Comment #4
drunken monkeyComment #5
shkiper CreditAttribution: shkiper as a volunteer commentedComment #6
borisson_I tested this, looks great.
Comment #7
drunken monkeyYeah, largely looks good. Just some minor documentation coding standards issues, a typo and a bit of shortening (
$index->clear()
already checks$index->status()
).Also, not in the interdiff (since that would have made it useless): Moved the command and method one position up, since I think it fits better there.
Also, this needed a re-roll anyways, due to #2682369: Fix problems with overridden config entities.
Comment #8
borisson_Let's get this in.
Comment #9
drunken monkeyThanks for reviewing!
Could someone also manually test whether this still works as expected? Would be good to hear.
In any case, this needed a re-roll due to #2268809: Use short array syntax in module.
Comment #10
borisson_Works great.
Comment #12
drunken monkeyGood to hear, thanks for testing!
Committed.
Thanks again, everyone!
(And … interesting tag!)