Tests for all Processors

I just went through all the processors for #2230931: Supporting multiple item types per index, and most of them haven't really been ported at all, with a weird mix of D7 and D8 code. So I guess most of the issues should really be "Properly port, test and write unit tests for X processor". Only Ignorecase (Ha! Also, should be IgnoreCase.) and RenderedItem at least look like they could work.

A roundup of where we stand wrt processor tests. These are the processors we have, along with tests (if any)

AddAggregation.php
AddURL.php
-- no test
CommentAccess.php
-- no test
HTMLFilter.php
-- ./tests/src/Plugin/Processor/SearchApiHtmlFilterTest.php
Highlight.php
-- ./tests/src/Plugin/Processor/SearchApiHighlightTest.php
Ignorecase.php
-- ./tests/src/Plugin/Processor/SearchApiIgnorecaseTest.php
Language.php
-- no test
NodeAccess.php
-- no test
NodeStatus.php
-- ./src/Tests/SearchApiNodeStatusProcessorTestCase.php
RenderedItem.php
-- no test
RoleFilter.php
-- no test
Stopwords.php
-- ./tests/src/Plugin/Processor/SearchApiStopwordsTest.php
Tokenizer.php
- no test
Transliteration.php
-- ./src/Tests/SearchApiTransliterationProcessorTestCase.php

NB the tests currently are in one of 2 directories, ./src/Tests (and extended from DrupalUnitTestBase, executable from drush/ui), or tests/src/Plugin/Processor (and extended from UnitTestCase, executabel from run-tests.sh - eg php core/scripts/run-tests.sh --class "Drupal\search_api\Tests\Plugin\Processor\SearchApiHtmlFilterTest").

As it stands, all tests pass, so we have three tasks here:
1 - decide upon whether to extend from DrupalUnitTestBase or UnitTestCase (I prefer UnitTestCase) and align the existing tests.
2 - complete tests for plugins which don't currently have them
3 - identify and address drunken_monkey's concerns

Finally, I think Ignorecase test is correctly named as the plugin is called Ignorecase :)

Finally, I think Ignorecase test is correctly named as the plugin is called Ignorecase :)

I meant that both should be changed, in my opinion: ID ignore_case, class IgnoreCase, test IgnoreCaseTest.

Also, if someone wants to work on this, I'd be happy to provide a more detailed explanation of what still needs to be changed for any processor they want to work on. But I thought, maybe this will happen in the sprint next week, when it will be also easier for me to explain.

Attaching a processor test base class that can be used in the individual processor tests.

I reworked tests for :
SearchApiTransliterationTest.php
SearchAPIIgnoreCaseTest.php

The tests now take an item to the processFields method that is more likely to be similar to a Drupal 8 field. Also fieldsProcessorBasePlugin.php was reworked a bit but that did not change the tests too much.

Diff can be seen here:
https://github.com/nickveenhof/search-api-sandbox/commit/58e407263b4b86f...
https://github.com/nickveenhof/search-api-sandbox/commit/3c71d02c6b0855d...

and I've worked on the tests for the HTML filter. Reporting progress in the other thread about that filter.

Changed the summary to reflect on the work that has been done in the Search API Sprint @ intracto during the 13th - 15th of June 2014, Belgium.

Thanks to everyone involved!

This means: drunken monkey, borisson_, ekes, Pieter Frenssen, Frederico Taramaschi, Sascha Grossenbacher, Mattias Michaux, LukyLuke_ch, Jasper Lammens, Bram Goffings and Andrei Mateescu

Thanks a lot for bringing this up-to-date!
And yes, thanks to everyone who helped this weekend!

Only the field processor plugin base class now …

Unbelievable, but it really seems we're done here!
Later, we can examine where we can improve coverage, but at the moment I think this is certainly good enough to proceed.

Great news!! A very nice milestone to reach, congratulations!