Starting to analyze the state of -- ./tests/src/Plugin/Processor/SearchApiStopwordsTest.php and to check if this processor is working or broken.

Comments

ekes’s picture

ekes commented

The default configuration isn't getting retrieved in buildConfigurationForm(). The default stopwords aren't populated and implode() has a type exception.

  • Commit d89bc3c on 2257113-Index-Processors-Fields by ekes: 
    Issue #2281233: Fixes stopword configuration value when not enabled.
ekes’s picture

ekes commented

Above patch is a bit grim, there maybe a better way. Looking at HTMLFilter it similarly deals with array or string - but automatically with the yaml dumper. The test that covers this is with the save/resave in the integration test https://drupal.org/node/2257113#comment-8877845

  • Commit d89bc3c on master, 2257113-Index-Processors-Fields by ekes: 
    Issue #2281233: Fixes stopword configuration value when not enabled.

  • Commit d89bc3c on master, 2230925-server-tasks, 2257113-Index-Processors-Fields by ekes: 
    Issue #2281233: Fixes stopword configuration value when not enabled.

  • Commit d89bc3c on master, 2230925-server-tasks, 2257113-Index-Processors-Fields, transliteration by ekes: 
    Issue #2281233: Fixes stopword configuration value when not enabled.

  • Commit d89bc3c on master, 2230925-server-tasks, 2257113-Index-Processors-Fields, transliteration, ignore-case-test-fix by ekes: 
    Issue #2281233: Fixes stopword configuration value when not enabled.

  • Commit d89bc3c on master, 2230925-server-tasks, 2257113-Index-Processors-Fields, transliteration, ignore-case-test-fix, 2281233-fix-stopwords by ekes: 
    Issue #2281233: Fixes stopword configuration value when not enabled.

  • Commit d89bc3c on master, 2230925-server-tasks, 2257113-Index-Processors-Fields, transliteration, ignore-case-test-fix, 2281233-fix-stopwords, ignorecase-nick, renamefields by ekes: 
    Issue #2281233: Fixes stopword configuration value when not enabled.

  • Commit d89bc3c on master, 2230925-server-tasks, 2257113-Index-Processors-Fields, transliteration, ignore-case-test-fix, 2281233-fix-stopwords, ignorecase-nick, renamefields by ekes: 
    Issue #2281233: Fixes stopword configuration value when not enabled.

  • Commit d89bc3c on master, transliteration, ignore-case-test-fix, ignorecase-nick, renamefields, highlight by ekes: 
    Issue #2281233: Fixes stopword configuration value when not enabled.

  • Commit d89bc3c on master, transliteration, ignore-case-test-fix, ignorecase-nick, renamefields, highlight, add-aggregation-nick by ekes: 
    Issue #2281233: Fixes stopword configuration value when not enabled.

  • Commit d89bc3c on master, transliteration, ignore-case-test-fix, ignorecase-nick, renamefields, highlight, add-aggregation-nick, 2247923-Test_the_RenderedItem_processor by ekes: 
    Issue #2281233: Fixes stopword configuration value when not enabled.

  • Commit d89bc3c on master, transliteration, ignore-case-test-fix, ignorecase-nick, renamefields, highlight, add-aggregation-nick, 2247923-Test_the_RenderedItem_processor, 2286813-fields-processor-plugin-base-test by ekes: 
    Issue #2281233: Fixes stopword configuration value when not enabled.
nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Active » Fixed

Marking as Fixed. Thanks to the people at the Search API sprint @ Intracto.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.