Needs following:
// @todo Re-introduce Datasource::getEntityType() for this?
// @todo Only process nodes (check '#datasource' key).

Comments

blueminds’s picture

blueminds commented
Related issues: +#2230881: Tests for all Processors
blueminds’s picture

blueminds commented
Parent issue: » #2230881: Tests for all Processors
Related issues: -#2230881: Tests for all Processors

updated eca1967..291e507

blueminds’s picture

blueminds commented
Status: Active » Needs review
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Looks good, thanks.
A later optimization could be to go through all datasources first in preprocessIndexItems() to find out which of them contain nodes, collect those in an associative array and then just check with isset() instead of that huge calling chain for each item.
Might at least be a bit cleaner to look at, even if the performance gain is probably pretty small even for large numbers of items.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.