In this patch, 2 different "pull allowed" hooks to address different pull use cases:
1. hook_salesforce_pull_record_allowed:
Prevent a Salesforce object from being added to the pull queue. For example, prevent pull of Contacts without email address.
2. hook_salesforce_pull_entity_allowed
Skip processing of a Salesforce pull queue item. For example, never pull to user 1.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | interdiff-2223669-11-12.txt | 1.71 KB | bdone |
| #12 | salesforce-hook_pull_allowed-2223669-12.patch | 6.08 KB | bdone |
| #11 | salesforce-hook_pull_allowed-2223669-11.patch | 6.3 KB | ruscoe |
| #10 | interdiff-2223669-8-10.txt | 6.45 KB | vaish |
| #10 | salesforce-hook_pull_allowed-2223669-10.patch.txt | 6.02 KB | vaish |
Comments
Comment #1
ohthehugemanatee commentedComment #2
kenorb commentedThis doesn't look right:
Comment #3
aaronbaumanMarking postponed on #2186153: Provide additional Salesforce push/pull hooks for pre_export changes.If that gets closed without a similar patch, this can get re-opened.
OK, scratch that.
Marking 2186153 as "won't fix", and working on a re-roll of this patch to address the use case.
Comment #4
aaronbaumanComment #5
labboy0276 commentedTested patch in #4, it works great, thanks!
Comment #6
aaronbaumanI think this needs to be combined with / subsumed by the proposed fix in #2688033: Add entity_presave/insert/update sf pull hooks
Comment #7
labboy0276 commentedEven better
Comment #8
wxactly commentedRe-rolling this patch for compatibility with 7.x-3.2.
Comment #9
mariacha1 commentedThe issue this was originally trying to solve -- preventing items from syncing based on some custom logic -- is technically fulfilled by #2688033: Add entity_presave/insert/update sf pull hooks but that method not only stops the sync but also throws a watchdog error. This leads to a lot of generally uninteresting and unimportant warnings in your logs. There is probably a better way to solve both problems. At the very least, I'd like this code to be more DRY. Put that copy/pasta in a function, yo!
Comment #10
vaish commentedPatch from #8 updated to make code more DRY.
Comment #11
ruscoe commentedRerolled patch from #10 against current 7.x-3.x-dev branch.
Comment #12
bdone commentedanother reroll. this one for #11 @ 7.x-3.x; adding minor coding standard fixes for "Doc comment short description must be on a single line, further text should be a separate paragraph", and ignoring type hinting.
Comment #13
bdone commentedthis a reroll of #12, but specifically for the 7.x-3.2 tag. please ignore for 7.x-3.x-dev.
Comment #14
bdone commentedComment #15
aaronbauman7.x is no longer supported