Only one billing or shipping address shown in address book tab for authentificated user

I can confirm this. Might be a commerce commerce core permission issue.

GOTCHA!
this was really hard to hunt:
* the other-addresses view add a left-join which must be NULL
* BUT commerce access control demands that uid=current-user if it sees this table

we might fix this by fixing commerce access control in a separate issue: #2238733: NULL queries break entity query access control

the simplest fix here is to make the view "all addresses". This is obsolete or can be reverted if the other issue is accepted and committed.

(So IF anyone wants to push this forward, please implement / review the other issue as well)

I can confirm this one as well, running version 7.x-2.0-rc7.

Logged in as authenticated user, I can add addresses and upon submitting I am receiving a "Profile updated" site message, but all I ever see is the original, default address. However, when I log-in as administrator, edit that previous user and click on "Address Book", all the addresses are listed correctly.

@bird-kid: what you describe is to be expected, as this issue is about permissions.

if you apply the patch and confirm it's a fix, this will be committed faster!

I am also experiencing this same problem and the patch did not seem to fix the issue.

At first I came to the the same solution as in the patch, then I tried only removing the relationship with commerce_addressbook_defaults from the original view and the problem seemed solved: without the default address being displayed twice! This does not make any sense, does it? :-)

@chowk128: After applying the patch you should revert the view to reload the default settings from the patched file, see admin/structure/views/view/commerce_addressbook/revert?destination=admin/structure/views/view/commerce_addressbook.

Thanks a lot. I can confirm that the patch works. And all addresses are now shown for authenticated users. Using 7.x-2.0-rc7

This patch alone on rc7 causes that the users second address gets set to default because of the problem with setting the default address on first anonymous checkout. So you need to apply the mentioned patch too: https://www.drupal.org/node/2112131

So RTBC as of #7.

I can confirm that the patch in comment 2 works for me as well.

Thanks,
-mike

The patch works!

Perfect, thanks.

I have read and all the threads related to this problem, I check the permissions and they are correct and I am on the latest version of the kickstart and even installed a clean version but the problem persist, I only see as the authenticated user the default view and not the view list which is what I need to show, I need the user can select the address for shipping and billing that they want... what can I do now?

Arsjok, just apply the patch from the comment #2.

Hi,

Sorry but this is not RTBC for me. As say, it would show all adresses, including defaults, which doesn't make sense (we have an issue about this new bug introduce by patch #2!).
And indeed, this is an access commerce entity issue which didn't check LEFT JOIN. Note that by itself, the original view is correct.

But hopefully, the commerce module provide a hook to alter the useless check for this LEFT JOIN.

So here is a patch which would display all adresses except defaults.
You should revert your view to the original and apply this patch instead.

I didn't really like the way to match the context because it is not really true (ugly check on table alias generated by views). And having the query in context to check if we have a LEFT JOIN on this table would be better but it works.
In other context (which ones?), I don't think that there is a security issue with this patch or break some stuff as it rely on LEFT JOIN with IS NULL.

Patch on #14 works for me. Thanks a lot!

Patch on #14 works for me as well. Thanks!

Indeed, #14 works!

I have the same problem (I think) using 7.x-2.0-rc8.
Under /user/<notadmin>/addressbook
I see only one default billing and one default shipping address.

I only see all the addresses for the current authenticated user if I enable
View any customer profile of any type
I don't then see addresses e.g. of Admin (node 1) or any other users in the current user
addressbook. But I can navigate to
/user/1/addressbook
and see the admin addressbook as this user.

Applying #14 with View any customer profile of any type SEEMS to make no difference. (e.g. /user/1/addressbook shows the admin addressbook). Applying #14 without View any customer profile of any type - only the 2 default addresses are shown.

What combination of patches and permissions do I need to get this right?

Patch #14 works for me. Many thanks.

I also found time to go to the root: Please test patch in #2238733: NULL queries break entity query access control.

Patch in #14 does not work for me.

• It does restore second profile, but only two.
• I have three profiles for my test user and only two show up in address book (before patch was only one!).
• Second profile is made default in address book. But first profile is selected in checkout.

Thanks

Patch in #2 does not work for me.

• It does restore all the customer profiles in the address book
• It does allow to set a profile as default profile
• (However, it shows the default profile twice, once above the others [presumably as the default, but not labeled as such], and once in the list of all profiles below. Is this as designed/
• But in checkout, the first profile is always selected

Patch mentioned at https://www.drupal.org/node/2112131 is already in the code in version 7.x-2.0-rc8

@Ryan Weal: Thanks for the advice, but you are mistaken. I was reporting all the apparent symptoms of this module mismanaging the addresses. Three patches are referenced here and there are multiple symptoms of what is or might be wrong. It's not going to be pretty. I understand and respect the guidelines for posting issue reports.

But in checkout, the first profile is always selected

Oh I think I spotted that too!

Very likely related to this issue:
#2419499: Element validate is not saving the order's customer profile field after setting it

Patches worked for me. I was only getting the full Address book view to show on administrator account and only the default address was showing on authenticated.

Hi,
Thanks for the patches. They work, but also bring a bug for me. It works fine when I input address in Germany. But when I input address in China, for example, the state/province field shows a 2-digital number rather than the state name. I took a screen shot, the number "11" should be shown as "Beijing".

I'm quite sure that is unrelated @glicn, and sounds like maybe a bug for addressfield module because that is where that field is coming from. Maybe report a new bug with them https://www.drupal.org/project/issues/addressfield?categories=1

Following

Having (still) the same issue as #1

Patch #14 works for me. Thanks.

So I was experiencing the same problem as the OP. As a site administrator I can see the list View of customer profiles provided by commerce_addressbook, but as an authenticated user I was only seeing the default profile View.

On my end it doesn't appear to be a permissions issue. Dumping out the raw SQL for both types of users I noticed that 1) there's a redundant LEFT JOIN with the commerce_customer_profile table that's being added via the Profile ID relationship in the View, and 2) The authenticated user gets a wonky little AND condition added into the query that our site admin doesn't.

I'm not sure where the AND condition is coming from, but I can't come up with a reason the "Addressbook: Profile ID" relationship is needed, and suffice it to say that removing it resolved my issue.

This patch removes that relationship from the two default Views provided.

#32 works for me.

The patch in #32 worked for me as well. Marking as RTBC.

#32 for the money shot! Extra relationship caused issue, patch fixed. Cross linked to #2541004: Add testing! to get a test added in later for this.

FWIW - I was using rc8, now using rc9 which contains #32 - and things "got better" - users could see more than one address but the set as default behaviour was making no sense.

I needed https://www.drupal.org/node/2570353 (View commerce_addressbook_defaults doesn't return default address correctly) as well.