Closed (fixed)
Project:
Chaos Tool Suite (ctools)
Version:
7.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
3 Mar 2014 at 23:21 UTC
Updated:
27 Jul 2016 at 00:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
blackclover commentedUpdated panels, views, entity and file entity to the latest dev versions and that fixed it. Sorry not sure which one was the culprit. Cheers.
Comment #2
lex0r commentedCorrect me if I'm wrong but you can't set "Closed (fixed)" status on a ticket with the buggy version unless it is fixed in that version? You should have used "Fixed" and close it only with a new release.
Sincerely,
your boring!
Comment #3
lex0r commentedThe patch for those of us who doesn't dare to use dev in production.
Comment #4
jaydarnellI hate to reopen an issue but the patch in #3 above did not remove these error messages for me...
Comment #5
jaydarnellDrupal 7.26
Ctools 7.x-1.4
Panels 7.x-3.4
I'm not savvy enough to know what the cause of this is but the patch above did not fix the problem. Please let me know if there are other bits of information I can provide to help reproduce this.
Comment #6
jaydarnellComment #8
dsquaredb commentedI have installed the latest dev version of ctools and am still getting this error message. Is there a fix that works?
Comment #9
sprite commentedI am also experiencing the following error message in ctools with:
Ctools 7.x-1.4
Panels 7.x-3.4
The problem appears after setting a panel context to a node and then referencing an - image - field from the contextual node on the content of the panel.
When I temporarily reverted to Ctools 7.x-1.3 to check if the problem was in that module and not some other, the problem disappeared.
The problem also persists in the latest - 7.x-1.x-dev - 2014-Aug-22 - development version of the ctools module.
Comment #10
timaholt commentedManually applying this patch worked for me but the patch itself doesn't apply cleanly to the latest head. I've re-rolled the patch.
Comment #11
timaholt commentedComment #12
timaholt commentedComment #14
reevo commentedPatch in #10 fails to apply. Attaching a reformatted version.
Comment #15
reevo commentedComment #17
dkane commentedPatch in #14 worked for me. Thanks!
Comment #18
segi commentedI tested the patch in #14 with ctools 7.x-1.7 and It seems to me the patch solved the problem. I tried to apply for current dev version and It was smooth so, I take it to to RTBC.
Comment #19
Anonymous (not verified) commentedPatch #14 worked for me also. Thank you!
Comment #21
japerryWow what a check. Looks good :-)
Comment #22
capfive commentedPatch #14 worked for me also, will upgrade to next version when it is out :) I "wouldn't dare upgrade to dev" :)
Comment #23
maximpodorov commentedThe last commit breaks already fixed issue #2195211: Warning after update: Missing argument 4 for entity_metadata_taxonomy_access (by reverting the part of the fix).
Comment #24
maximpodorov commentedThe patch fixes the problem described in #23.
Comment #25
eric115 commentedPatch in #24 works as intended.
Comment #26
eric115 commentedMarking this issue as a child issue to Plan for CTools 7.x-1.11 release.
Comment #27
maximpodorov commentedI think new release with urgent fixes should follow. See https://www.drupal.org/node/2195211#comment-10247879 - the current release broke already fixed things.
Comment #28
adrien.felipe commentedExact same issue here. Was generating the patch but @davidwhthomas did it already :)
For some reason 2 arguments from line 188
, $account, $to_entity)) {keep being deleted from the code, while actually leaving the variables unused on the previous code.The patch from https://www.drupal.org/node/2195211#comment-10247879 fixes the issue.
I also vote RTBC
Comment #29
mglaman+1 this break Drupal Commerce + Panels.
Comment #30
eric_a commentedComment #31
eric_a commentedComment #32
anybodyConfirming the problem and the working patch. A fix is urgently required. Thanks a lot for your hard work!
Comment #33
nickdickinsonwildeWorks and be ideal to get this into the release stream ASAP.
Comment #34
dsnopekWe're now using this patch in Panopoly.
Comment #35
maxplus commentedThanks,
patch #24 solved my issue (coming from issue https://www.drupal.org/node/2195211)
Comment #36
torgospizzaPatch in #24 also worked for me, coming from a Drupal Commerce issue #2608754: commerce_entity_access incorrect access logic [fixed in Ctools 1.x-dev]. Would be nice to have this committed!
Comment #37
xen commentedConfirmed that it removes the warning from https://www.drupal.org/node/2195211 .
Inspecting the patches, it's clear that #10 is a mis-reroll that cuts of the arguments added since the original patch was written.
#24 adds the missing arguments.
Comment #38
dobe commented#24 worked for me.
Comment #39
sketman commented#24 worked for me too, thanks.
Comment #40
mustanggb commentedComment #42
japerryPatch 24 it is then! Looks good, committed.
Comment #43
maximpodorov commentedThank you.