Some of these issues are going to be changed with the update to the issue queue styles. But it's worth noting what some of the existing color contrast issues are for the goal of WCAG 2.0 AA with the site.

  • Buttons green #9FC748 on white - This is large text so it could be as light as #7c9f31 - If it were smaller text it would need to be #587022.
  • The grey #9D9D93 "Upload" button & "Add another item" buttons should be #8f8f83 even if they are seen as big.
  • The green #96BC44 "Use Default Homepage" text should get darkened to #718e33 even with large texts.
  • The green #668A19 View, Edit, Revisions tabs probably should also be darker. It is debatable if it is large text or not. If it isn't considered large text it should be as dark as #526f14.
  • Header blue background #56B3E6 with white text - the background might need to be as dark as #1976a7 - Similar to https://drupal.org/node/2125621
  • The buttons in the header are dark blue #0D7DC1 with white text, but again it should be darker #0b68a1.
  • Issue queue - Blue text #0678BE on pink background #FFECE8, the grey background #F9F9F9 and the green background #D7FFD8 - All can be fixed if we make the blue a bit darker it is fine #05639d.
  • The red #FF0000 "updated" text is also problematic on these backgrounds. It should be darkened to #df0000 to be visible on all backgrounds.
  • In the footer, the Blue text #0678BE against the light grey #F6F6F2 doesn't work. Making the text a bit darker to #05639d works.
  • In the files tables for issues the grey text #777777 and the blue text #0678BE on grey #EEEEE0 and even the #999999 even white isn't dark enough. It should be something like #6a6a6a.

Looking at pages like:

Comments

mgifford’s picture

Issue summary: View changes
mgifford’s picture

Issue summary: View changes
mgifford’s picture

Issue summary: View changes
mgifford’s picture

Issue summary: View changes
mgifford’s picture

Issue summary: View changes
mgifford’s picture

Status: Active » Needs review
  • #9FC748 - No longer in Bluecheese
  • #9D9D93 - is in _variables.scss:$grey
  • #96BC44 - is commented out // Lime Green #96BC44 rgb(150,188,68)
  • #668A19 - No longer in Bluecheese
  • #56B3E6 - No longer in Bluecheese
  • #0D7DC1 - is commented out // Light Navy Blue #0D7DC1 rgb(13,125,193)
  • #0678B - is commented out 2X // Dark Blue #0678BE rgb(6,120,190) // Blue links #0678BE
  • #FF0000 & #F00 - No longer in Bluecheese
  • #777 - No longer in Bluecheese
  • #f6f6f2 - is in _variables.scss & styles.css:$pale-yellow: #f6f6f2;

Here's a patch to help get this rolling.

mgifford’s picture

StatusFileSize
new959 bytes
drumm’s picture

Status: Needs review » Needs work

Sorry, I didn't notice the patch among all the issue updates.

In the footer, the Blue text #0678BE against the light grey #F6F6F2 doesn't work. Making the text a bit darker to #05639d works.

The change in the patch for this changes the background to the darker blue, which I'm sure isn't intended.

mgifford’s picture

Status: Needs work » Needs review
StatusFileSize
new959 bytes

Woops.. Fixed it. Thanks! With all the changes to the summary it was indeed easy to miss the patch.

I'm pretty certain I got the values from http://webaim.org/resources/contrastchecker/ but then paste in the wrong hex code.

The lighter/darker code really isn't fine tuned enough in that Webaim tool.

I updated the Pale Yellow rgb codes too. One concern with $pale-yellow is that I really don't see it as being "pale yellow" now http://www.color-hex.com/color/fafaf7

Not that this is really a change as it didn't look at all yellow to me before.

Bojhan’s picture

I'd like to have before/after screenshots for all of this. Frankly we did our best and validated the designs previously, so I am not sure what changed. This issue mixes a lot of different things, from navigation to issue file tables.

danigrrl’s picture

Bohjan, do you need before/after screenshots for the pages, or would it be easy enough to do swatches? I'd be happy to put something together.

mgifford’s picture

This tool would probably be better at finding closer color combinations that also meet WCAG 2 AA.
http://contrast-finder.tanaguru.com

drumm’s picture

Status: Needs review » Postponed (maintainer needs more info)
StatusFileSize
new64.41 KB

$grey is used in 7 places throughout the theme, and $pale-yellow in 15 places. This is enough to definitely need testing.

I think this definitely needs work. For example, here is this form:

Screenshot with new colors

The fieldsets are barely identifiable to me. Is this intentional? Have these colors been tried out on a Drupal.org dev site?

mgifford’s picture

Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new3.61 KB

I can pick/choose a variety of colors, but really it's hard for me to choose a better one that is accessible without knowing what thought went into the present ones. The Webaim tool is pretty coarse, and there are way better options provided via http://contrast-finder.tanaguru.com - still someone has to choose what's going to look good.

Retrofitting for accessibility always takes a lot more work as we have to second guess what the intentions were.

Ok, here are the remaining color contrast issues:

  • The grey #9D9D93 "Upload" button & "Add another item" buttons
  • the Blue text #0678BE against the light grey #F6F6F2

But let's also remove the unused clutter:

  • Dark Blue #0678BE rgb(6,120,190)
  • Lime Green #96BC44 rgb(150,188,68)
  • Light Navy Blue #0D7DC1 rgb(13,125,193)
  • Blue links #0678BE

And have the names make sense:

  • $light-yellow -> $white
  • $pale-yellow: #F6F6F2 -> #F9FEC1 (or do you want to have a $light-grey2 instead)
  • GrayGrey #9D9D93 rgb(157,157,147) - we should be consistent

Most of the use of $grey is actually associated with borders. That doesn't really matter for accessibility.
Maybe all $grey should be 20% darker as per sass/partials/common/_forms.scss: color: darken($grey, 20%); for greater consistency?
The accessibility problem I initially pointed out was from sass/partials/common/_basic-elements.scss we could just do make that variable darker, but then is that defeating the point of using variables:

    button {
      background: darken($grey, 20%);
    }

Likewise, we could have the same impact here sass/partials/drupalorg/_front.scss:

#front-drupal-stats .inner  {
  border-top: 1px solid $light-grey;
  color: darken($grey, 20%);

And no, I haven't tried this on a dev environment.

Bojhan’s picture

Could we please evaluating whether certain styling is purely decorative before making everything basically black and white. As far as I am concerend the issue queue styling is merely additional encapsulation of information, the spacing alone should be enough.

I'm close to just won't fixing this issue, since its a plethora of different issues from navigation, issue comment background - while other comments reference the issue listings.

We have no clear guidelines what we are doing, what elements should comply, how we try to solve a11y issues (not just changing colours, lets consider adding elements like a border etc). We are not doing any visual reviews (no screenshot are provided).

mgifford’s picture

StatusFileSize
new35.5 KB
new35.95 KB
new35.83 KB

Working on Drupal.org dev environments is really frustrating. It's pretty rare that I have time to do it, and when I do I never know when/where to apply changes. I always feel like I'm going to step on someone's work.

We can't apply Bluecheese on SimplyTest.me unfortunately. That would be the easiest.

I'm definitely not making things black & white, but the CSS for Bluecheese really could use a good cleanup. Variables should mean something, even when the colors change.

I really don't care if the background is #F9FEC1 or #FAFAEE or if we change the link color to #0274C5. From a design perspective, the actual light-yellow background would be a huge change (and isn't needed).

But ya, guidelines on how to do this would be nice. These should be pretty simple changes that most folks probably won't even notice (but will matter to folks with low vision).

kattekrab’s picture

Priority: Normal » Major

Maybe this could be revisited again with the redesign work that's going on, and while we're improving colour contrast for syntax highlighting.

I'm going to increase the priority to major - meeting basic accessibility guidelines should be a priority.

joelpittet’s picture

Issue tags: +a11y

@kattekrab, if the scope is to expand it may be good to make this in to a Plan and spin off some child issues to tackle each component that needs addressing on it's own.

charles belov’s picture

[Deleted]

andrewmacpherson’s picture

Issue tags: -a11y

Tag clean up: "accessibility" is the preferred one. The "a11y" tag doesn't have many issues so I'm moving them all to "accessibility".