Needs review
Project:
Bluecheese
Version:
7.x-1.x-dev
Component:
User interface
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
28 Feb 2014 at 03:47 UTC
Updated:
8 Feb 2017 at 11:21 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
mgiffordComment #2
mgiffordComment #3
mgiffordComment #4
mgiffordComment #5
mgiffordComment #6
mgiffordHere's a patch to help get this rolling.
Comment #7
mgiffordComment #8
drummSorry, I didn't notice the patch among all the issue updates.
The change in the patch for this changes the background to the darker blue, which I'm sure isn't intended.
Comment #9
mgiffordWoops.. Fixed it. Thanks! With all the changes to the summary it was indeed easy to miss the patch.
I'm pretty certain I got the values from http://webaim.org/resources/contrastchecker/ but then paste in the wrong hex code.
The lighter/darker code really isn't fine tuned enough in that Webaim tool.
I updated the Pale Yellow rgb codes too. One concern with $pale-yellow is that I really don't see it as being "pale yellow" now http://www.color-hex.com/color/fafaf7
Not that this is really a change as it didn't look at all yellow to me before.
Comment #10
Bojhan commentedI'd like to have before/after screenshots for all of this. Frankly we did our best and validated the designs previously, so I am not sure what changed. This issue mixes a lot of different things, from navigation to issue file tables.
Comment #11
danigrrl commentedBohjan, do you need before/after screenshots for the pages, or would it be easy enough to do swatches? I'd be happy to put something together.
Comment #12
mgiffordThis tool would probably be better at finding closer color combinations that also meet WCAG 2 AA.
http://contrast-finder.tanaguru.com
Comment #13
drumm$greyis used in 7 places throughout the theme, and$pale-yellowin 15 places. This is enough to definitely need testing.I think this definitely needs work. For example, here is this form:
The fieldsets are barely identifiable to me. Is this intentional? Have these colors been tried out on a Drupal.org dev site?
Comment #14
mgiffordI can pick/choose a variety of colors, but really it's hard for me to choose a better one that is accessible without knowing what thought went into the present ones. The Webaim tool is pretty coarse, and there are way better options provided via http://contrast-finder.tanaguru.com - still someone has to choose what's going to look good.
Retrofitting for accessibility always takes a lot more work as we have to second guess what the intentions were.
Ok, here are the remaining color contrast issues:
But let's also remove the unused clutter:
And have the names make sense:
GrayGrey #9D9D93 rgb(157,157,147) - we should be consistentMost of the use of $grey is actually associated with borders. That doesn't really matter for accessibility.
Maybe all $grey should be 20% darker as per sass/partials/common/_forms.scss:
color: darken($grey, 20%);for greater consistency?The accessibility problem I initially pointed out was from sass/partials/common/_basic-elements.scss we could just do make that variable darker, but then is that defeating the point of using variables:
Likewise, we could have the same impact here sass/partials/drupalorg/_front.scss:
And no, I haven't tried this on a dev environment.
Comment #15
Bojhan commentedCould we please evaluating whether certain styling is purely decorative before making everything basically black and white. As far as I am concerend the issue queue styling is merely additional encapsulation of information, the spacing alone should be enough.
I'm close to just won't fixing this issue, since its a plethora of different issues from navigation, issue comment background - while other comments reference the issue listings.
We have no clear guidelines what we are doing, what elements should comply, how we try to solve a11y issues (not just changing colours, lets consider adding elements like a border etc). We are not doing any visual reviews (no screenshot are provided).
Comment #16
mgiffordWorking on Drupal.org dev environments is really frustrating. It's pretty rare that I have time to do it, and when I do I never know when/where to apply changes. I always feel like I'm going to step on someone's work.
We can't apply Bluecheese on SimplyTest.me unfortunately. That would be the easiest.
I'm definitely not making things black & white, but the CSS for Bluecheese really could use a good cleanup. Variables should mean something, even when the colors change.
I really don't care if the background is #F9FEC1 or #FAFAEE or if we change the link color to #0274C5. From a design perspective, the actual light-yellow background would be a huge change (and isn't needed).
But ya, guidelines on how to do this would be nice. These should be pretty simple changes that most folks probably won't even notice (but will matter to folks with low vision).
Comment #17
kattekrab commentedMaybe this could be revisited again with the redesign work that's going on, and while we're improving colour contrast for syntax highlighting.
I'm going to increase the priority to major - meeting basic accessibility guidelines should be a priority.
Comment #18
joelpittet@kattekrab, if the scope is to expand it may be good to make this in to a
Planand spin off some child issues to tackle each component that needs addressing on it's own.Comment #19
charles belov[Deleted]
Comment #20
andrewmacpherson commentedTag clean up: "accessibility" is the preferred one. The "a11y" tag doesn't have many issues so I'm moving them all to "accessibility".