Now with #2047803: Port common structures and field formatter to Drupal 8 done it makes sense to focus on some more specific porting efforts in dedicated issues.

Currently the views support is not yet ported in any way, so that will need some focused attention. Given that most views "stuff" was already "plugins" in D7 I'm hoping this will not be too crazy of a task... but who knows.

CommentFileSizeAuthor
#9 juicebox-viewsstyle_plugin_incomplete-2188157-9.patch36.92 KBrjacobs
#7 juicebox-viewsstyle_plugin_incomplete-2188157-7.patch36.92 KBrjacobs
#6 juicebox-viewsstyle_plugin_incomplete-2188157-6-do-not-test.patch33.28 KBrjacobs
#4 juicebox-views_style_plugin_scaffolding-2188157-4-do-not-test.patch13.02 KBrjacobs

Comments

rjacobs’s picture

rjacobs commented

This probably can't be 100% completed until #2273731: Filters throw unrecoverable error when using relationships is fixed as we depend on some entity methods to detect which views fields can be used for titles/captions, and that detection triggers the error reported there.

jastraat’s picture

jastraat commented

It looks like the referenced core issue has been closed, so is there a plan to start porting the views support?

rjacobs’s picture

rjacobs commented

Hi,

I started some work on this not too long ago, but didn't commit anything yet.

With the field formatter port I was getting a bit frustrated by the number of times I needed to redo ported code on account of continuous fluctuation in the Drupal core betas. It's possible that I started that effort too early (though it was insightful to monitor, and help debug, some parts of core as a result). Anyway, because of this I decided to purposely wait until core stabilized a bit more to fully tackle the views integration part.

I guess I could commit the views style plugin "scaffolding" that I have in case others want to help out with that in the meantime.

rjacobs’s picture

rjacobs commented
StatusFileSize
new juicebox-views_style_plugin_scaffolding-2188157-4-do-not-test.patch13.02 KB

In case anyone is interested, here is what I have so far. The plugin already contains most everything for the integration of the Juicebox configuration options into a style formatter, but the actual build/render methods are not there yet.

rjacobs’s picture

rjacobs commented
Component: Code » Views Integration

Setting proper component value for issue tracking purposes.

rjacobs’s picture

rjacobs commented
StatusFileSize
new juicebox-viewsstyle_plugin_incomplete-2188157-6-do-not-test.patch33.28 KB

Getting pretty close now. I'm attaching a patch that's almost functionally complete. The XML generation methods still need to be taken care of though.

rjacobs’s picture

rjacobs commented
Status: Active » Needs review
StatusFileSize
new juicebox-viewsstyle_plugin_incomplete-2188157-7.patch36.92 KB

This should be pretty close to feature complete... though test coverage is still missing.

rjacobs’s picture

rjacobs commented

Update referenced file.

rjacobs’s picture

rjacobs commented
StatusFileSize
new juicebox-viewsstyle_plugin_incomplete-2188157-9.patch36.92 KB

Guess I have to re-submit to trigger testbots.

  • rjacobs committed dd04c47 on 8.x-2.x 
    Issue #2188157 by rjacobs: D8 port views style plugin
rjacobs’s picture

rjacobs commented
Status: Needs review » Fixed

Quite a lot of changes here so I went ahead with the commit and will handle some additional test coverage in a follow-up: #2586125: Finalize test coverage for view style plugin functionality.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.