missing help text

Thanks for reporting @jiv_e. I can reproduce the issue and at first look I thought might be introduced by #1691342: field description is displayed multiple times. But it is not. However I couldn't really get the bottom of it.

Thanks for working on this. @jiv_e. Here is some code level comments. Will have a manual check and would be great to have some tests to cover this cases.

1. +++ b/date.theme
   @@ -374,7 +374,7 @@ function theme_date_combo($variables) {
   -    '#description' => !empty($element['#fieldset_description']) ? $element['#fieldset_description'] : '',
   +    '#description' => !empty($element['#description']) ? t($element['#description']) : '',
   

   not sure, why can't we keep the field_description here?

2. +++ b/date_elements.inc
   @@ -331,8 +331,11 @@ function date_combo_element_process($element, &$form_state, $form) {
   -  $description =  !empty($element['#description']) ? t($element['#description']) : '';
   -  unset($element['#description']);
   

   Unset is to avoid duplicate of them, which doesn't looks like covered in this patch anymore

3. +++ b/date_elements.inc
   @@ -375,8 +378,7 @@ function date_combo_element_process($element, &$form_state, $form) {
   -    $element['#fieldset_description'] = $description;
   +    $element['#description'] .= '<span class="js-hide"> ' . t("Empty 'End date' values will use the 'Start date' values.") . '</span>';
   

   Again, why not fieldset_description?

Thanks @jiv_e for the patch. From a functionality perspective it works perfectly. I re-rolled it against 7.x-2.8 to test locally without any issues. Good job :)

Marking it as 'Reviewed & tested by the community' as it's been a year and nobody has said it's a problem.

Would it be possible to get this rolled into a release?

this needs tests coverage

Patch didn't apply, so re-rolled with minor coding style fixes.

The patch in #14 worked for our purposes.

It looks like this is fixed & working; can I post here to get an auto notification when the issue is 'resolved' and it's rolled out?
thanks (and apologies if I've done something wrong...!)

Using patch #14 doesn't work with localize_fields.

Here's a simpler patch that does work in my case, but removes the extra text added regarding the start / end components.

Patch in #20 applied, but didn't help me. I modified the patch in #14 and removed the t() which is not required for field strings, I think they are automatically running through t() anyway. Now it works and I can translate the string normally from Drupal UI.

Rerolled #5 on top of the new 2.9 release

This also fixes an issue where the help text doesn't display when the "Render as a regular field" option is used on a non-repeating date field.

Very funny, after applying patch #22, if I tick Render as a Regular Field, both field label and help text can be translated under Node & Entityform but Profile2 shows Untranslated Label with Translated Help Text.

How come only Label is NOT translated in Profile2 ? I'd never encountered situation like this.

Any ideas ? Thanks

Hi,
Referring to #24, I traced out the cause of why label wasn't translated in Profile2 when using Date-Popup widget.

Could someone create a patch for date/date_popup/date_popup.module at line 326 as follows ?

Original

      $element['date']['#title'] = check_plain($element['#instance']['label']);
      $element['date']['#required'] = $element['#required'];
    }
    elseif (empty($element['date']) && !empty($element['time'])) {
      $element['time']['#title'] = check_plain($element['#instance']['label']);

Changed To

      $element['date']['#title'] = t(check_plain($element['#instance']['label']));
      $element['date']['#required'] = $element['#required'];
    }
    elseif (empty($element['date']) && !empty($element['time'])) {
      $element['time']['#title'] = t(check_plain($element['#instance']['label']));

I'm not familiar with creating a patch and just manually modified the codes.

Thanks

I can confirm that #22 fixes the issue I was experiencing whereby a standard single value date field (in my case on a user profile) was not displaying the configured help text.

Nitpicking here, but we need to stick to the d.o. coding standards

1. +++ b/date_elements.inc
   @@ -337,8 +337,11 @@ function date_combo_element_process($element, &$form_state, $form) {
   +  if(isset($element['show_repeat_settings']) && !empty($element['value']['#instance']['description'])) {
   

   Space after if

2. +++ b/date_elements.inc
   @@ -337,8 +337,11 @@ function date_combo_element_process($element, &$form_state, $form) {
   +    //Date repeat is a multiple value field. So the description is removed from the
   

   Space after //.
   the goes past the 80 char limit.

Fixes for the minor coding standards mistakes.

LGTM

+++ b/date.theme
@@ -402,7 +402,7 @@ function theme_date_combo($variables) {
+    '#description' => !empty($element['#description']) ? t($element['#description']) : '',

The t-function is not necessary: this function should never be used to translate variables. Translating the field description can be be done with i18n_field.

Updated the patch based on feedback above. Can confirm this is working as expected. Can we get this merged?

While you shouldn't mark your own patch as RTBC, the patch looks good and the only change is removal of the t() function.

Apologies, I thought I'd selected Needs Review! Must have mis-clicked.

Only unanswered item is #25 which doesn't look like related to this issue @paulwdru, please check the issue queue for related issue and if not found, create a new issue for the title translation issue you are facing.