[D7] Google Universal Analytics

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

I've checked the code and added some small todo's. This is mostly comment stuff. The actual programmatic code looks good and is ready for production sites.

There are some errors & warnings reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxtomvv2183537git

There are issue reported by pareview.sh, please have these fixed.

The code has been fixed.

Just checked preview & the issues are still present. Those needs to be resolved before moving this to RTBC

Now preview.sh does't show any errors anymore: http://pareview.sh/pareview/httpgitdrupalorgsandboxtomvv2183537git

fabianderijk thanks for updating the issue. This application is still not ready for RTBC, as GIT brach naming starndards are not followed.

Follow the guide @ Release naming conventions and create appropriate name for your branches as per standard.
Follow the guide @ Setting a default branch and set appropriate default branch

Once the branch names are fixed you can change the STATUS of this issue to NEEDS REVIEW so that someone from the community will review & make it RTBC

I've just merged the develop & 7.x-1.x branch.

There is still a master branch, you have to delete it:
http://pareview.sh/pareview/httpgitdrupalorgsandboxtomvv2183537git

That is not an application blocker, please do a real manual review.

Klausi,

i know, that is why I didn't put it in my own issue as a review.

Please delete branches other than 7.x-1.x (not a blocker thou)

Application Blocker
existing google_analytics - module already supports universal analytics. I don't understand the clear reason behind a new module to do the same task ? As you are aware our Drupal community strongly believe Collaboration rather than competition

Per the application description existing google analytics module is heavy !! can we quantify what does that mean ? how is it stated that existing module heavy ?

Ref :
https://drupal.org/contribute/development
https://drupal.org/node/23789

Furthermore, the Universal Analytics integration is still in dev state in the main Google Analytics module. Integration and cooperation with this module will be considered though. Still I believe at this point, other developers are looking for the features in this module as hard as I did before.

From a developer, site builder, and maintainers perspective I would rather see the cooperation happen now than creating yet another module for Google Analytics.

We already have problems on Drupal.org of modules that support the same services on the web but implement them in different ways. Case in point is the "Search API Solr" and "Apachesolr" modules. Luckily the two maintainers of those modules are starting to get together and hash a way forward.

So I would, as a developer, plead the case that this project here be put toward updating the existing Google Analytics module and not creating another module.

Duplication

This sounds like a feature that should live in the existing google_analytics project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the google_analytics issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.