Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webflo’s picture

Status: Active » Needs review
Issue tags: +SprintWeekend2014, +D8MA
FileSize
5.22 KB
dawehner’s picture

Status: Needs review » Needs work

Sadly we have to update the composer autoloader file here.
In general it is semantically great that the composer.json file depends our currently existing dependency

Missing files:

* rebuild_token_validator.sh
* password-hash.sh
* run-tests.sh
* ...

webflo’s picture

Removed bootstrap.inc from rebuild_token_validator, password-hash and run-tests. Dumped the new autoloader, but skipped the hash change.

dawehner’s picture

Status: Needs work » Needs review

.

The last submitted patch, 1: load-bootstrap-inc-with-composer-2181757-1.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 3: load-bootstrap-inc-with-composer-2181757-3.patch, failed testing.

tstoeckler’s picture

Hmm... our good old friend "Call to a member function get() on a non-object in /var/lib/drupaltestbot/sites/default/files/checkout/core/lib/Drupal.php on line 157"

dawehner’s picture

Status: Needs work » Needs review
FileSize
10.67 KB
5.87 KB

There are sadly a couple of problems. Due to the loading of the bootstrap.inc in our autoloader
it will also leak into the phpunit tests, which for sure causes all kind of problematic behaviors.

This just fixes the ones which appear when we run phpunit via phpunit, let's see what the other ones are.

Status: Needs review » Needs work

The last submitted patch, 8: 2181757-bootstrap-7.patch, failed testing.

tstoeckler’s picture

8: 2181757-bootstrap-7.patch queued for re-testing.

The last submitted patch, 8: 2181757-bootstrap-7.patch, failed testing.

tstoeckler’s picture

8: 2181757-bootstrap-7.patch queued for re-testing.

Mile23’s picture

Mile23’s picture

What specific use-cases need to be addressed?

Mile23’s picture

Issue tags: +Composer
webflo’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.