When you view the site in a different language than English, the icon on the first toolbar link misses.

This is caused by the translation of the classname (toolbar-icon-inhoud instead of toolbar-icon-content, in Dutch).

See screenshot, I added the classnames below. For some strange reason, only Content is translated, where the other items work fine.

Toolbar item Content misses icon

CommentFileSizeAuthor
#5 1.jpg78.46 KBNikitaJain
#3 2150331-3.patch767 bytesrpayanm
#1 2150331-missing-icon-for-content-link.patch1.03 KBBarisW
toolbar-content-icon.png27.47 KBBarisW

Comments

BarisW’s picture

BarisW commented
Component: toolbar.module » system.module
Status: Active » Needs review
StatusFileSize
new 2150331-missing-icon-for-content-link.patch1.03 KB

I think I found the bug. The Standard Profile inserts menu links (node/add, admin/content and ), with a t() function added.

Example:

<?php
$menu_link = entity_create('menu_link', array(
    'link_path' => 'admin/content',
    'link_title' => t('All content'),
    'weight' => -19,
  ));
?>

The link titles go through t() later in the process, so we should not use the t() function when adding menu links. The patch removes the t() wrappers in the standard.profile.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll
rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 2150331-3.patch767 bytes

mgifford queued 3: 2150331-3.patch for re-testing.

NikitaJain’s picture

NikitaJain commented
StatusFileSize
new 1.jpg78.46 KB

Not able to reproduce the issue.
Steps:
1. Selected Dutch language at the time of installation of Drupal 8 set-up.
2. Icon is appearing for content link toolbar when viewing in 'Dutch' language.
Screenshot attached.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs review » Closed (cannot reproduce)

Thanks for confirming @NikitaJain! This appears to have been fixed elsewhere, closing out.