I find myself generating entityform submissions during the commerce checkout process and I'd like to keep them in draft status until checkout completes. However, there doesn't seem to be a rules action that allows me to change the submission draft flag from TRUE to FALSE. Using Set a data value tells me the The selected data property doesn't support writing, so that's a no go.

Attached patch creates an action which sets the Draft status to FALSE and saves the submission. It's defined in entityform.rules.inc, so won't affect installations that don't have rules installed.

CommentFileSizeAuthor
#8 entityform-draft_setter-2146395-8.patch481 bytestedbow
#3 Screen Shot 2013-11-29 at 3.44.44 pm.png47.91 KBcafuego
#3 2146395-entityform-draft-action-3.patch725 bytescafuego
entityform-draft-action-1.patch1.25 KBcafuego
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cafuego’s picture

cafuego CreditAttribution: cafuego commented
Status: Active » Needs review
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
CreditAttribution: tedbow commented
Status: Needs review » Needs work

You shouldn't have to have specific action for this.

We just need to set the 'setter callback' property in:
EntityformMetadataController:: entityPropertyInfo()
here: http://drupalcode.org/project/entityform.git/blob/refs/heads/7.x-2.x:/en...

Then Rules will be able to set the property and you won't get The selected data property doesn't support writing,

cafuego’s picture

cafuego CreditAttribution: cafuego commented
Status: Needs work » Needs review
FileSize
2146395-entityform-draft-action-3.patch725 bytes
Screen Shot 2013-11-29 at 3.44.44 pm.png47.91 KB

Added the property with a setter callback, as per screenshot.

I'm not sure how to override the checkbox label of it that's even possible without adding a custom setter callback.

The last submitted patch, 3: 2146395-entityform-draft-action-3.patch, failed testing.

The last submitted patch, 3: 2146395-entityform-draft-action-3.patch, failed testing.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
CreditAttribution: tedbow commented

3: 2146395-entityform-draft-action-3.patch queued for re-testing.

The last submitted patch, 3: 2146395-entityform-draft-action-3.patch, failed testing.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
CreditAttribution: tedbow commented
FileSize
entityform-draft_setter-2146395-8.patch481 bytes

@cafuego, here is version of the patch that passes the tests. Can you confirm this lets you change the draft property via a Rules action?

We only need to set the 'setter callback' b/c other properties are set via:
$info = parent::entityPropertyInfo();

Thanks

cafuego’s picture

cafuego CreditAttribution: cafuego commented
Status: Needs review » Reviewed & tested by the community

Yup, that works just fine - thank you :-)

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
CreditAttribution: tedbow commented
Status: Reviewed & tested by the community » Fixed

Ok, I have committed and fixed this

cafuego’s picture

cafuego CreditAttribution: cafuego commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.