A followup to #1406948: Clean up and remove includes/media.variables.inc, all of the variables currently used by media have an extra underscore following the standard module name prefix. Variables should be renamed to follow the standard naming convention.

CommentFileSizeAuthor
#1 remove-variable-legacy-namespace-2145319-1.patch17.42 KBdevin carlson

Comments

devin carlson’s picture

devin carlson commented
Status: Active » Needs review
StatusFileSize
new remove-variable-legacy-namespace-2145319-1.patch17.42 KB

A patch to remove the extra underscore from variable names.

Status: Needs review » Needs work

The last submitted patch, 1: remove-variable-legacy-namespace-2145319-1.patch, failed testing.

devin carlson’s picture

devin carlson commented
Status: Needs work » Needs review

1: remove-variable-legacy-namespace-2145319-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: remove-variable-legacy-namespace-2145319-1.patch, failed testing.

devin carlson’s picture

devin carlson commented
Status: Needs work » Needs review

1: remove-variable-legacy-namespace-2145319-1.patch queued for re-testing.

devin carlson’s picture

devin carlson commented
Status: Needs review » Fixed
Related issues: +#2145901: Rebuild dependencies for Media

Tested #1, checking for any broken functionality and running the update function to see if variables were successfully migrate and removed when appropriate. I didn't come across any functional issues or problems with the update function (variables we/weren't set, had set values vs. empty/NULL values, etc).

Committed #1 to Media 7.x-2.x.

This patch brought to you by the fine folks in charge of the Drupal.org Testbots #2145901: Rebuild dependencies for Media.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.