Closed (fixed)
Project:
D7 Media
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
16 Jan 2012 at 18:16 UTC
Updated:
4 Jan 2014 at 01:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
devin carlson commentedTaking a stab at this.
Changes:
media_variable_default().media_variable_name()and incorporated the media variable namespace directly into the administrationstaticto&drupal_staticmedia_variable_default()to return NULL when the default value of a variable has not been set (per the existing documentation)Moved the modified code to media.module.
Comment #3
devin carlson commentedRerolled.
Comment #5
devin carlson commentedAnd once more.
Comment #6
dave reidI also want to get rid of media_variable_set() and media_variable_del() as those only do namespacing. For the default variables and media_variable_get() let's do the following:
Comment #7
ParisLiakos commentedComment #8
jerdavisFollowing up on this as the current state of Media (in official and dev releases as of today) results in errors when attempting to run database updates. In particular, media_update_7206() fails as it is trying to call media_variable_get() and failing. Either these changes need to be pushed through or a module_load_include('inc', 'media', 'includes/media.variables'); needs to be added to this update for it to complete.
Comment #9
ParisLiakos commented@#18 http://drupalcode.org/project/media.git/commit/e2c3a74 and http://drupalcode.org/project/media.git/commit/ed0cc08 should take care of that.
i think we should consider integrating with variable module..right now media.variables.inc, just does what variable module would for free..
Comment #10
dave reidLet's put this as a beta blocker. I do not want to add a dependency on the variable module. If it is worth doing optional integration, I would consider that, but I just want us to use normal variable_get() calls.
Comment #11
ParisLiakos commentednormal variable_get() calls is fine. i proposed variable module as the media.variables.inc replacement..removing it entirely without replacement is fine too :)
Comment #12
devin carlson commentedA patch to convert every occurrence of media_variable_* to variable_*.
Once this is in, I'll file a followup to remove the double underscore from the variable names.
Comment #13
devin carlson commentedA reroll after #2076499: Double trailing slash in theme_media_formatter_large_icon() causes invalid image style tokens in some environments.
Comment #14
devin carlson commentedRetested #13 and didn't run into any problems.
Committed to Media 7.x-2.x.