In privatemsg-alternatives.js line 7

$('<a>') is not valid, should be $('<a/>') or $('<a></a>')

most browsers will assume this anyway, but IE [10 and 11] do not.

CommentFileSizeAuthor
#5 privatemsg_unclosed_a_tag_in_privatemsg-alternatives.js-2141031-5.patch593 bytesptmkenny
#2 unclosed_a_tag_in_privatemsg-alternatives.js-2141031-0.patch538 bytesfinne

Comments

finne’s picture

finne
Primary language Dutch
Location Amsterdam
commented
Issue summary: View changes

This results in the private message drupal message that allows you to choose a user when user ref has two identical names to be emptied in internet explorer 10 and 11, because the a tag is not valid. Attached patch solves this.

finne’s picture

finne
Primary language Dutch
Location Amsterdam
commented
StatusFileSize
new unclosed_a_tag_in_privatemsg-alternatives.js-2141031-0.patch538 bytes

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: unclosed_a_tag_in_privatemsg-alternatives.js-2141031-0.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review

Not sure what's wrong with the tests, but can be ignored as this is a JS only test that couldn't be tested anyway.

However, it would be great to have a patch for 7.x-2.x as well. Should be similar.

ptmkenny’s picture

ptmkenny commented
Version: 6.x-2.x-dev » 7.x-2.x-dev
StatusFileSize
new privatemsg_unclosed_a_tag_in_privatemsg-alternatives.js-2141031-5.patch593 bytes

Here's a patch for 7.x-2.x-dev.

System Lord’s picture

System Lord commented

I patch manually. Can someone explain this? Thanks!

@@ -39,4 +39,4 @@
     }
   }
 
-})(jQuery);
\ No newline at end of file
+})(jQuery);

This is what it currently looks like (before the patch) for this file.

        // Remove the span.
        $(this).remove();
      })
    }
  }

})(jQuery);
System Lord’s picture

System Lord commented

I'm only aware of new patch lines beginning with "+". Does "\" mean something?

ptmkenny’s picture

ptmkenny commented

This is a standard git patch.

https://www.drupal.org/patch/apply

dgtlmoon queued 2: unclosed_a_tag_in_privatemsg-alternatives.js-2141031-0.patch for re-testing.

The last submitted patch, 2: unclosed_a_tag_in_privatemsg-alternatives.js-2141031-0.patch, failed testing.

  • Berdir committed f58a179 on 6.x-2.x authored by ptmkenny 
    Issue #2141031 by finne, ptmkenny: unclosed a tag in privatemsg-...
  • Berdir committed e374041 on 7.x-2.x authored by ptmkenny
    Issue #2141031 by finne, ptmkenny: unclosed a tag in privatemsg-...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Committed to 6.x-2.x and 7.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.