We would need this to complete the porting of quiz module (#1964284: Quiz module for Drupal 8).

Comments

sivaji_ganesh_jojodae’s picture

lussoluca’s picture

Hi module mantainers,
we need a D8 version of this module too, to provide graphical representation for profiles collected with the new webprofiler module.

We have done an initial port of Charts module to D8, you can find it here. We have defined a set of classes to describe the chart (similar with the actual element_info) but more developer friendly and now the chart implementations are done with plugin. We have implemented the Google Charts version only and there isn't any integration with Views. The complete examples suite (charts/examples) works. If you like this approach we can go on finishing a first complete version for D8.

Thanks

Luca

Pierre.Vriens’s picture

Priority: Normal » Major
sharique’s picture

@lussoluca, or anybody who has understanding about this module, can you please create sub tasks for it, so that people can start working on it?

Pierre.Vriens’s picture

Pierre.Vriens’s picture

Completing #2382151: Charts 7.x-2.0 Release seems like a prereq before working on this issue makes sense (I think). After that got completed, the D8 upgrade of charts seems like a must for the next version of charts (#2395779: Charts 7.x-3.x Release) .

Also, I think that upgrading charts to D8 does not at all relate to yes or no upgrading the chart module to D8, which is why I suggest to remove the related chart issue here.

Pierre.Vriens’s picture

Status: Active » Needs work
quicksketch’s picture

I recently had a volunteer (andileco) email me about a D8 version of charts, which has been mostly completed and is available on Github: https://github.com/andileco/d8charts

As this module hasn't seen much work in the past year or more, and the fact that D8 versions of modules tend to be almost entirely different from their D7 counter-parts, I suggest that we let andileco copy his version of the module into the main Charts repository.

andileco’s picture

Thanks @quicksketch for directing me to this issue. I had been using this one: https://www.drupal.org/node/2623176

My colleague @mwebaze and I have been doing a ton of work to try and port this module over. The link @quicksketch provided will work in D8 (use Composer from the submodule directories to pull in their respective libraries), but we need a lot of help with things like code documentation, naming conventions, and tests.

We also want people to try out the code in ways that we wouldn't have necessarily considered.

If you are willing to help, please request to be a contributor to https://github.com/andileco/d8charts

I'd love to post the code to this module so that people can see some progress is being made and so that I can use pareview.sh to continue to fix PHPDoc, spacing, etc.

andileco’s picture

Assigned: Unassigned » andileco
Pierre.Vriens’s picture

To the extend you want to know about my feedback on this: Great news, go go go!

However, at the same time I'd like to add a (friendly) reminder/explanation related to the "As this module hasn't seen much work in the past year or more" in #8 ... i.e. related to what I wrote in my comment in #2368793-32: Chart 2.0 (about 2 years ago, still waiting/hoping for "some" reply): any answer is fine, but after waiting about 2 years, "an" answer would be appreciated.

andileco’s picture

Hi @Pierre.Vriens, thanks for the support! I got started on porting the module before I saw this thread. We have probably progressed beyond a point to which we could easily say "this version of the D8 charts matches up with X release of D7 charts." For example, we included a third submodule (charts_c3) and we extend Views's Attachment plugin instead of creating a Chart Add-on plugin from scratch.

I don't know that there is a clear upgrade path from D7...but we aim to fully recreate the features from D7 and more. And I have made some attempts to include feature requests from D7 that are not yet incorporated. For example, in the style plugin (currently line 244), you'll see:

// @todo incorporate this patch: https://www.drupal.org/files/issues/charts_grouping-2146927-6.patch.

(which refers to https://www.drupal.org/node/2146927)

Would you be willing to test this version module (the GitHub link), see how it works (granted, there are still a number of things that need to be done...), and then provide some thoughts in response to the question about if it needs to reflect a 2.x or a 3.x release?

We definitely want to produce the go-to charting module for Drupal 8!

quicksketch’s picture

Status: Needs work » Needs review

That's great Pierre.Vriens you're on board as well.

@andileco: You may find it's either feast or famine with contributor involvement, and that's generally okay. Any kind of commitment is pretty much on the table with GPL software. I took over this project from an abandoned D6 version, Pierre effectively took it over from me, and now you're likely to carry the torch. Keep in mind that to your own needs be true.

I've granted you full access to the project repo, page, and releases. I'd encourage you to move the code into the Drupal repository (or at least mirror it there) and make an alpha or beta release immediately, as any kind of release will substantially increase the amount of testers you will get and make your bug reports substantially more accurate. Welcome aboard and we're so very excited to have your involvement. :)

andileco’s picture

Status: Needs review » Fixed

There's now an alpha version

andileco’s picture

Status: Fixed » Closed (fixed)