Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
jQuery Update has finally added support for jQuery 1.9 - 1.10.
Running either version throws "Uncaught TypeError: Cannot read property 'msie' of undefined"
The $.browser method has been removed as of jQuery 1.9.
The jQuery.browser() method has been deprecated since jQuery 1.3 and is removed in 1.9.
— jQuery Core 1.9 Upgrade Guide. http://jquery.com/upgrade-guide/1.9/
Comment | File | Size | Author |
---|---|---|---|
#14 | panels-jquery_gt_1.9-D6-2135377-14.patch | 1.79 KB | jarrodirwin |
#5 | panels-jquery_gt_1.9-2135377-5.patch | 2.31 KB | hswong3i |
Comments
Comment #1
axe312 CreditAttribution: axe312 commentedAs we do in admin_menu, we should drop IE6 support. See here: https://drupal.org/comment/8255187
Why? IE6 is dead! See here:
http://www.w3schools.com/browsers/browsers_explorer.asp (0.1%)
http://www.netmarketshare.com/report.aspx?qprid=3&qpaf=&qpcustom=Microso... (4.92%)
http://gs.statcounter.com/#browser_version-ww-monthly-201211-201311-bar (IE6 is no more listed)
http://www.w3counter.com/globalstats.php (IE6 is no more listed)
http://clicky.com/marketshare/global/web-browsers/internet-explorer/ (0.33%)
Ill post a patch in the next few hours! :)
Comment #2
axe312 CreditAttribution: axe312 commentedComment #3
axe312 CreditAttribution: axe312 commentedHere's the patch. Panels is still working smoothly in IE7+ :)
Comment #4
axe312 CreditAttribution: axe312 commentedComment #5
hswong3i CreditAttribution: hswong3i commentedPatch re-roll via panels GIT 7.x-3.x with format-patch, now applied to drustack_extra.make and tested with jquery 1.10.2 without error message, thank you very much ;-)
Comment #6
hswong3i CreditAttribution: hswong3i commentedComment #7
travisc CreditAttribution: travisc commentedtested #5 and the patch appears to work as intended, please commit.
Comment #8
japerrySo this looks to be just some IE specific code to make panels work in IE6. Can someone verify for me the following browsers still work with panels?
MSIE 8,9,10 (7 is said to work) on windows 7, 8 (depending on msie version)
I've tested Firefox and Chrome on OSX and don't see any issues (with or w/o jQuery update enabled), mainly because the code is only supposed to work with IE. However, I want to verify this doesn't break anything within IE before it gets committed. Sadly I don't have resources to spin up those other environments, I hope someone else here can!
I'm pretty sure we're good to go, but just in case. Thanks!
Comment #9
japerryI was able to get some testers to verify other versions of IE. We're good here.
Committed:
http://drupalcode.org/project/panels.git/commit/f2f4cce
Comment #10
axe312 CreditAttribution: axe312 commentedI wrote the patch and get no reward? sad story!
Comment #13
peterx CreditAttribution: peterx commented@axe312 +1 for your patch. It fixes a roadblock I hit this morning. If you drop in here at lunchtime today, I will buy you a beer. :-)
Comment #14
jarrodirwin CreditAttribution: jarrodirwin commentedIf anyone needs it, here is the same patch re-rolled for the current D6 Dev branch
Comment #15
capfive CreditAttribution: capfive commentedI'm note sure if there was any reason for this not fixing my issue, but I have the exact same (with latest version of panels) and I can't get it working on 1.9 or above...
Any one else having problems?
Comment #16
japerryif you can post the errors you're getting, that'd help. I'll review patches, as long as the patch also supports jquery that is shipped with D7 core.
Comment #17
capfive CreditAttribution: capfive commentedNo problems thanks for the help :)
I actually just enabled 1.10 and this is working for me.
i did change the provider to google, not sure if that helped as well
Comment #18
MustangGB CreditAttribution: MustangGB commentedRestoring status then.
Comment #19
zkrebs CreditAttribution: zkrebs commentedI am using jQuery update 7.x-2.7 and Panels 7.x-3.8+0-dev
jQuery Update Settings
Default jQuery version 1.10
Alt jQuery version for Admin 1.7
Panels IPE editor does not load when clicking "Customize This Page"
Receive these errors in Console:
Interestingly enough, the Overlay seems to be causing this issue somehow.
Comment #20
zkrebs CreditAttribution: zkrebs commentedI could never get this to work properly, so what I did was use https://www.drupal.org/project/jquery_update 7.x-3.0-alpha3 which lets me select a jQuery version per theme. I am using one theme for panels pages, one theme for my Bootstrap 3/SooperThemes page which need higher jQuery version.