jQuery Update has finally added support for jQuery 1.9 - 1.10.

Running either version throws "Uncaught TypeError: Cannot read property 'msie' of undefined"

The $.browser method has been removed as of jQuery 1.9.

The jQuery.browser() method has been deprecated since jQuery 1.3 and is removed in 1.9.

— jQuery Core 1.9 Upgrade Guide. http://jquery.com/upgrade-guide/1.9/

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

axe312’s picture

axe312’s picture

Assigned: Unassigned » axe312
axe312’s picture

Here's the patch. Panels is still working smoothly in IE7+ :)

axe312’s picture

Status: Active » Needs review
hswong3i’s picture

Assigned: axe312 » Unassigned
Status: Needs review » Reviewed & tested by the community
FileSize
2.31 KB

Patch re-roll via panels GIT 7.x-3.x with format-patch, now applied to drustack_extra.make and tested with jquery 1.10.2 without error message, thank you very much ;-)

hswong3i’s picture

Title: Support jQuery Update 7.x-2.x-dev » Support jQuery >= 1.9
travisc’s picture

tested #5 and the patch appears to work as intended, please commit.

japerry’s picture

Status: Reviewed & tested by the community » Needs review

So this looks to be just some IE specific code to make panels work in IE6. Can someone verify for me the following browsers still work with panels?

MSIE 8,9,10 (7 is said to work) on windows 7, 8 (depending on msie version)

I've tested Firefox and Chrome on OSX and don't see any issues (with or w/o jQuery update enabled), mainly because the code is only supposed to work with IE. However, I want to verify this doesn't break anything within IE before it gets committed. Sadly I don't have resources to spin up those other environments, I hope someone else here can!

I'm pretty sure we're good to go, but just in case. Thanks!

japerry’s picture

Status: Needs review » Fixed

I was able to get some testers to verify other versions of IE. We're good here.

Committed:
http://drupalcode.org/project/panels.git/commit/f2f4cce

axe312’s picture

I wrote the patch and get no reward? sad story!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

  • Commit f2f4cce on 7.x-3.x, 8.x-3.x authored by hswong3i, committed by japerry:
    Issue #2135377 by travisc, hswong3i: Enable jQuery 1.9 support, drop...
peterx’s picture

@axe312 +1 for your patch. It fixes a roadblock I hit this morning. If you drop in here at lunchtime today, I will buy you a beer. :-)

jarrodirwin’s picture

If anyone needs it, here is the same patch re-rolled for the current D6 Dev branch

capfive’s picture

Status: Closed (fixed) » Active

I'm note sure if there was any reason for this not fixing my issue, but I have the exact same (with latest version of panels) and I can't get it working on 1.9 or above...

Any one else having problems?

japerry’s picture

if you can post the errors you're getting, that'd help. I'll review patches, as long as the patch also supports jquery that is shipped with D7 core.

capfive’s picture

No problems thanks for the help :)

I actually just enabled 1.10 and this is working for me.

i did change the provider to google, not sure if that helped as well

MustangGB’s picture

Status: Active » Closed (fixed)

Restoring status then.

zkrebs’s picture

I am using jQuery update 7.x-2.7 and Panels 7.x-3.8+0-dev

jQuery Update Settings
Default jQuery version 1.10
Alt jQuery version for Admin 1.7

Panels IPE editor does not load when clicking "Customize This Page"

Receive these errors in Console:

Uncaught Error: Syntax error, unrecognized expression: .error, #overlay-context=2016
    at Function.at.error (jquery.min.js:4)
    at mt (jquery.min.js:4)
    at Function.at [as find] (jquery.min.js:4)
    at $.fn.init.find (jquery.min.js:5)
    at HTMLFieldSetElement.<anonymous> (js_iCL-CfDP6eP0JLjeNEksmSbbQpKQRwRfiLodveVfp6U.js:1278)
    at Function.each (jquery.min.js:4)
    at $.fn.init.each (jquery.min.js:4)
    at $.fn.init.$.fn.once (js_Qn69YDSj3xZDZ8N_wdBsW6qEmWsVqHd_aCiUKChKO-Y.js:1)
    at Object.attach (js_iCL-CfDP6eP0JLjeNEksmSbbQpKQRwRfiLodveVfp6U.js:1278)
    at Object.<anonymous> (js_Qn69YDSj3xZDZ8N_wdBsW6qEmWsVqHd_aCiUKChKO-Y.js:4)

Interestingly enough, the Overlay seems to be causing this issue somehow.

zkrebs’s picture

I could never get this to work properly, so what I did was use https://www.drupal.org/project/jquery_update 7.x-3.0-alpha3 which lets me select a jQuery version per theme. I am using one theme for panels pages, one theme for my Bootstrap 3/SooperThemes page which need higher jQuery version.