Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The title for the form is check_plained further up the line, so the %item placeholder that wraps in the em tag, gets escaped..
Shall we fix it in ConfigItemGroup::buildForm? or further up (not sure where that is happening right now)?
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 2126983.patch | 814 bytes | olli |
| Screenshot 2013-11-04 12.15.53.png | 32.48 KB | damiankloip | |
| vdc-config-item-group-double.patch | 1003 bytes | damiankloip | |
Comments
Comment #1
dawehnerI am not sure but this sounds just wrong.
Comment #2
dawehnerIn other words, I think it is right to use for the admin label here.
Comment #3
damiankloip CreditAttribution: damiankloip commentedAlso, the regular ConfigItem form does not use the % placeholder, and I think these should just be consistent.
Comment #4
jibranI think #2100959: Views secondary action links escapes html twice qualified as related issue.
Comment #5
olli CreditAttribution: olli commentedIn js/modal the title works with 8e08650. Without js it is broken in d7 too.
Comment #6
olli CreditAttribution: olli commentedPatch does not apply anymore. #2102489: Remove drupal_set_title in views module controllers (last instance of drupal_set_title() in modules) fixed this for no-js.
Comment #7
olli CreditAttribution: olli commentedIs this just for ConfigItemGroup? If you go to admin/structure/views/view/who_s_new and click to change the display name, the title of the dialog is "Who's new: The name and the description of this display". Should I file another issue?
Comment #8
olli CreditAttribution: olli commentedHere's a fix in views_ajax_form_wrapper().
Comment #9
damiankloip CreditAttribution: damiankloip commentedAre you saying we should only fix it there? Not tested this at all yet :)
Comment #10
olli CreditAttribution: olli commentedNot pretty but that's the idea :)
Our title is html but jquery dialog title is text. This is kind of similar to page title code in template_preprocess_html().
Comment #11
olli CreditAttribution: olli commentedIt seems it could be possible to add support for html title, see #2207247-6: Dialog titles double escaped for views handlers and delete forms. Applying #2255369: DialogController does not respect $content['#title'] for the page title with #2254935: Use a modal for content entity form delete links confirmation forms or #2253257: Use a modal for entity delete operation links shows that this is not only a views ui issue.
Comment #20
LendudeCleaning up old bugs.
I think this got fixed by #2207247: Dialog titles double escaped for views handlers and delete forms. If you feel this is still an issue, please feel free to re-open this issue.