The title for the form is check_plained further up the line, so the %item placeholder that wraps in the em tag, gets escaped..

Shall we fix it in ConfigItemGroup::buildForm? or further up (not sure where that is happening right now)?

CommentFileSizeAuthor
#8 2126983.patch814 bytesolli
Screenshot 2013-11-04 12.15.53.png32.48 KBdamiankloip
vdc-config-item-group-double.patch1003 bytesdamiankloip

Comments

dawehner’s picture

dawehner
Primary language German
commented

The title for the form is check_plained further up the line, so the %item placeholder that wraps in the em tag, gets escaped..

I am not sure but this sounds just wrong.

dawehner’s picture

dawehner
Primary language German
commented

In other words, I think it is right to use for the admin label here.

damiankloip’s picture

damiankloip commented

Also, the regular ConfigItem form does not use the % placeholder, and I think these should just be consistent.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

I think #2100959: Views secondary action links escapes html twice qualified as related issue.

olli’s picture

olli commented

In js/modal the title works with 8e08650. Without js it is broken in d7 too.

olli’s picture

olli commented
Status: Needs review » Needs work

Patch does not apply anymore. #2102489: Remove drupal_set_title in views module controllers (last instance of drupal_set_title() in modules) fixed this for no-js.

olli’s picture

olli commented

Is this just for ConfigItemGroup? If you go to admin/structure/views/view/who_s_new and click to change the display name, the title of the dialog is "Who's new: The name and the description of this display". Should I file another issue?

olli’s picture

olli commented
StatusFileSize
new 2126983.patch814 bytes

Here's a fix in views_ajax_form_wrapper().

damiankloip’s picture

damiankloip commented

Are you saying we should only fix it there? Not tested this at all yet :)

olli’s picture

olli commented

Not pretty but that's the idea :)

Our title is html but jquery dialog title is text. This is kind of similar to page title code in template_preprocess_html().

olli’s picture

olli commented

It seems it could be possible to add support for html title, see #2207247-6: Dialog titles double escaped for views handlers and delete forms. Applying #2255369: DialogController does not respect $content['#title'] for the page title with #2254935: Use a modal for content entity form delete links confirmation forms or #2253257: Use a modal for entity delete operation links shows that this is not only a views ui issue.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs work » Closed (cannot reproduce)
Issue tags: +Bug Smash Initiative

Cleaning up old bugs.

I think this got fixed by #2207247: Dialog titles double escaped for views handlers and delete forms. If you feel this is still an issue, please feel free to re-open this issue.