a) Regarding the config page for update.module... admin/reports/update/settings ... I don't think I can find that config page except from the Extend page where it shows it as the configuration link (from the update.info.yml file)

configure: update.settings

This should be under Configuration, shouldn't it?

b) The settings page title is "Available Updates" and it is showing as if it is the Available Updates page (the "List" tab on the page is highlighted as active).
screen shot of settings page

c) From the modules (Extend) page, there is a tab that says "Update" but what it actually is for is installing new modules, not updating modules. It should say "Install", shouldn't it?

d) Same from the themes (Appearance) page.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Bojhan’s picture

Issue tags: +Usability

...

InternetDevels’s picture

Issue summary: View changes
Status: Active » Needs review
FileSize
2.3 KB

This patch for change paths to tabs.

Status: Needs review » Needs work

The last submitted patch, 2: drupal8update-changepathsoftabs-2121725-2.patch, failed testing.

marthinal’s picture

Status: Needs work » Needs review
jhodgdon’s picture

Some screen shots showing what this patch does would help in the review. :)

xjm’s picture

Status: Needs review » Needs work

The last submitted patch, 2: drupal8update-changepathsoftabs-2121725-2.patch, failed testing.

amitgoyal’s picture

Issue summary: View changes
Status: Needs work » Needs review
FileSize
2.28 KB

Patch in #2 no longer applies. So please see updated patch.

jhodgdon’s picture

Issue tags: +Needs screenshots

Could someone make some "after" screen shots (and maybe a few "before" screen shots if the ones in the issue summary are not enough) to show what this patch does? Thanks!

Devin Carlson’s picture

An updated patch which moves the update manager settings to a dedicated page under admin/config/development as mentioned in a). The page title was changed from "Available Updates" to "Update manager" as mentioned in b).

Available updates report page

The "settings" tab is no longer present as it was moved to a dedicated configuration page.

New configuration page

Identical to the old "settings" tab.

Module update tab

Now displays the update page instead of the "Install new module" local action as mentioned in c).

Theme update tab

Now displays the update page instead of the "Install new theme" local action as mentioned in d).

Bojhan’s picture

I am not to sure about this at all. We shouldn't put this so prominently in configuration, its merely a small report setting? Cant it just be tab of some reporting settings?

This shouldn't be labeled "Update Manager" that sets the expectation it has a highly usable function, it doesn't it can only help you with setting e-mail reminders.

laughnan’s picture

I don't know if this applies, but at /admin/reports/updates/update I see the following page. Links aren't rendering correctly.

Screenshot of the update page and bad links.

Devin Carlson’s picture

I'm no longer able to duplicate the settings page title and tab issue.

Attaching a simplified version of #10 that only includes the bug fix (correcting the "Update" tab on the appearance/extend/updates pages to point to their update status pages instead of their install pages). The fix is still demonstrated by the last two screenshots in #10.

I think relocating the update module settings could be done in a separate issue as it is now currently located in the same place as it was in D7 (as a tab on the Available updates page).

@laughnan see #2297711: Fix HTML escaping due to Twig autoescape for a meta issue around fixing double-escaping due to Twig autoescape.

jhodgdon’s picture

We still need to do this I think?

idebr’s picture

@jhodgdon It appears the changes from #13 were added in #2362205: admin/theme/install|update should point to admin/appearance/update|install. Can you confirm this solves the issue (or update the issue summary if it doesn't)?

jhodgdon’s picture

Status: Needs review » Closed (duplicate)

Agreed - everything that was identified in the issue summary as really terrible UI has already been fixed. So I'll just mark this as a duplicate of whatever other issues fixed the problems.