Problem/Motivation

If you to to admin/appearance and click on the "update" tab you will land at admin/theme/install. Indented though is admin/theme/update.

Similarly for admin/modules: the "update" tab brings you to admin/modules/install, but admin/modules/update was intended.

And also for admin/reports/updates: the "update" tab brings you to admin/reports/updates/install, but admin/reports/updates/update is intended.

Proposed resolution

Update update.links.task.yml to point the tasks to the right routes.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Comments

devin carlson’s picture

Status: Active » Needs review
StatusFileSize
new887 bytes

A patch from #2121725: UI badness in update.module (menus, tabs, etc.) which only address the problems mentioned in this issue ("update" tabs bring you to "install" pages).

It doesn't touch the page title.

wim leers’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Manually tested, fixes the problem. Clarified the IS.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

We can test that the tabs are taking you to the correct places.

wim leers’s picture

I personally don't see the value in writing tests for something as simple as task links. Surely we don't do this for every task link?

devin carlson’s picture

Status: Needs work » Needs review
Issue tags: -Needs tests
StatusFileSize
new2.12 KB
new2.99 KB

Added unit tests for Update's local tasks as was done for Aggregator, Book, etc.

The last submitted patch, 5: fix-update-tab-paths-2362205-5-tests-only.patch, failed testing.

effulgentsia’s picture

Status: Needs review » Reviewed & tested by the community

Tests look nice and consistent with the local task tests from other modules.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 77f7577 and pushed to 8.0.x. Thanks!

alexpott’s picture

This issue addresses a major bug and is allowed per #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase?. Committed 77f7577 and pushed to 8.0.x. Thanks!

  • alexpott committed 77f7577 on
    Issue #2362205 by Devin Carlson | dawehner: Fixed admin/theme/install|...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.