Problem/Motivation
If you to to admin/appearance and click on the "update" tab you will land at admin/theme/install. Indented though is admin/theme/update.
Similarly for admin/modules: the "update" tab brings you to admin/modules/install, but admin/modules/update was intended.
And also for admin/reports/updates: the "update" tab brings you to admin/reports/updates/install, but admin/reports/updates/update is intended.
Proposed resolution
Update update.links.task.yml to point the tasks to the right routes.
Remaining tasks
None.
User interface changes
None.
API changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | fix-update-tab-paths-2362205-5.patch | 2.99 KB | devin carlson |
| #5 | fix-update-tab-paths-2362205-5-tests-only.patch | 2.12 KB | devin carlson |
| #1 | fix-update-tab-paths-2362205-1.patch | 887 bytes | devin carlson |
Comments
Comment #1
devin carlson commentedA patch from #2121725: UI badness in update.module (menus, tabs, etc.) which only address the problems mentioned in this issue ("update" tabs bring you to "install" pages).
It doesn't touch the page title.
Comment #2
wim leersManually tested, fixes the problem. Clarified the IS.
Comment #3
alexpottWe can test that the tabs are taking you to the correct places.
Comment #4
wim leersI personally don't see the value in writing tests for something as simple as task links. Surely we don't do this for every task link?
Comment #5
devin carlson commentedAdded unit tests for Update's local tasks as was done for Aggregator, Book, etc.
Comment #7
effulgentsia commentedTests look nice and consistent with the local task tests from other modules.
Comment #8
alexpottCommitted 77f7577 and pushed to 8.0.x. Thanks!
Comment #9
alexpottThis issue addresses a major bug and is allowed per #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase?. Committed 77f7577 and pushed to 8.0.x. Thanks!