7.x-2.x copy of #1243544: Rules integration for Google Analytics goals tracking..

CommentFileSizeAuthor
#6 Issue-2121093-Support-custom-events-via-Rules.patch4.7 KBhass
#3 google_analytics-add-event-rules-action-2121093-3.patch4.52 KBnvahalik
#2 google_analytics-add-event-rules-action-2121093-2.patch3.49 KBnvahalik
#1 google_analytics-add-event-rules-action-2121093-1.patch3.45 KBnvahalik

Comments

nvahalik’s picture

nvahalik commented
Status: Active » Needs review
StatusFileSize
new google_analytics-add-event-rules-action-2121093-1.patch3.45 KB

Here is the 7.x-2.x version of the patch.

nvahalik’s picture

nvahalik commented
StatusFileSize
new google_analytics-add-event-rules-action-2121093-2.patch3.49 KB

Updating because of a problem we found testing the module.

nvahalik’s picture

nvahalik commented
StatusFileSize
new google_analytics-add-event-rules-action-2121093-3.patch4.52 KB

Actually, here's the correct patch ;)

hass’s picture

hass commented
Issue summary: View changes
Issue tags: +Needs tests

@nvahalik: I'd like to get this in, but are you able to write some tests, please?

hass’s picture

hass commented
Related issues: +#2306281: Context module integration

Asking me if rules integration makes still sense!?

hass’s picture

hass commented
StatusFileSize
new Issue-2121093-Support-custom-events-via-Rules.patch4.7 KB

I found a validation hook in rules API. Maybe this works a bit easier? Changed the patch based on API docs. Fully untested.

I cannot test anything here as I'm blocked by #2306551: Module completly broken, cannot enable.

hass’s picture

hass commented
Status: Needs review » Needs work

Tests are missing.

The last submitted patch, 6: Issue-2121093-Support-custom-events-via-Rules.patch, failed testing.

hass’s picture

hass commented

Looks like 'validation' functions are not working at all and all 'textfield' are 'text' fields. Also every text field shows a token selector and PHP evaluator under the text fields.

That is really not what we want.

plazik’s picture

plazik commented

GA Push module supports Rules integration and works with Universal Analytics.