It looks extremely useful to implement context module integration. I solved several issues at once this way. Currently I'm re-factoring the code and plan to write tests.

This feature will allow configuration of:

  • Context depended Events
  • Context depended Experiments
  • Context depended Content Groups
  • Context depended Custom code snippets

Required:

CommentFileSizeAuthor
#18 Issue-2306281-Context-module-integration.patch31.5 KBhass
#14 Issue-2306281-Context-module-integration.patch31.43 KBhass
#12 Issue-2306281-Context-module-integration.patch31.83 KBhass
#10 Issue-2306281-Context-module-integration_0.patch31.42 KBhass
#8 Issue-2306281-Context-module-integration.patch31.42 KBhass
#7 Issue-2306281-Context-module-integration.patch22.32 KBhass
#6 Issue-1686874-Context-module-integration.patch18.75 KBhass
#4 Issue-1686874-Context-module-integration.patch18.39 KBhass
#1 Issue-1686874-Context-module-integration.patch18.39 KBhass
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hass’s picture

hass CreditAttribution: hass commented
Status: Active » Needs review
FileSize
Issue-1686874-Context-module-integration.patch18.39 KB

First work in progress patch.

hass’s picture

hass CreditAttribution: hass commented
Issue summary: View changes

Status: Needs review » Needs work

The last submitted patch, 1: Issue-1686874-Context-module-integration.patch, failed testing.

hass’s picture

hass CreditAttribution: hass commented
Status: Needs work » Needs review
FileSize
Issue-1686874-Context-module-integration.patch18.39 KB

Status: Needs review » Needs work

The last submitted patch, 4: Issue-1686874-Context-module-integration.patch, failed testing.

hass’s picture

hass CreditAttribution: hass commented
Status: Needs work » Needs review
FileSize
Issue-1686874-Context-module-integration.patch18.75 KB
hass’s picture

hass CreditAttribution: hass commented
FileSize
Issue-2306281-Context-module-integration.patch22.32 KB
  • Edit UI code removed, seems not required.
  • Up to 5 Events can be configured per context
  • Events array will be reduced to configured items for faster processing.
  • Added form validation as good as possible.
hass’s picture

hass CreditAttribution: hass commented
FileSize
Issue-2306281-Context-module-integration.patch31.42 KB

Added tests. Final.

Status: Needs review » Needs work

The last submitted patch, 8: Issue-2306281-Context-module-integration.patch, failed testing.

hass’s picture

hass CreditAttribution: hass commented
Status: Needs work » Needs review
FileSize
Issue-2306281-Context-module-integration_0.patch31.42 KB

Suxxx EGit bug

Status: Needs review » Needs work

The last submitted patch, 10: Issue-2306281-Context-module-integration_0.patch, failed testing.

hass’s picture

hass CreditAttribution: hass commented
Status: Needs work » Needs review
FileSize
Issue-2306281-Context-module-integration.patch31.83 KB

Status: Needs review » Needs work

The last submitted patch, 12: Issue-2306281-Context-module-integration.patch, failed testing.

hass’s picture

hass CreditAttribution: hass commented
FileSize
Issue-2306281-Context-module-integration.patch31.43 KB
hass’s picture

hass CreditAttribution: hass commented
Status: Needs work » Needs review

  • hass committed 115a48a on 7.x-2.x 
    Issue #2306281: Enable testing with dependencies

Status: Needs review » Needs work

The last submitted patch, 14: Issue-2306281-Context-module-integration.patch, failed testing.

hass’s picture

hass CreditAttribution: hass commented
Status: Needs work » Needs review
FileSize
Issue-2306281-Context-module-integration.patch31.5 KB

  • hass committed 650af0e on 7.x-2.x 
    Issue #2306281: Context module integration
hass’s picture

hass CreditAttribution: hass commented
Version: 7.x-2.x-dev » 8.x-2.x-dev
Status: Needs review » Patch (to be ported)

  • hass committed ad83bd5 on 7.x-2.x 
    Revert "Issue #2306281: Enable testing with dependencies"

This reverts...
  • hass committed ef6cf80 on 7.x-2.x
    Revert "Issue #2306281: Context module integration"

This reverts commit...
hass’s picture

hass CreditAttribution: hass commented
Status: Patch (to be ported) » Needs work

Leaving it out as long as it is clear how D8 looks like. I read rumors context may be replaced by rules.

Plazik’s picture

Plazik CreditAttribution: Plazik as a volunteer commented

@hass , why it was removed from 7.x-2.x version? We could use these opportunities before D8.

hass’s picture

hass CreditAttribution: hass commented

I rolled it back as it was not clear how and if this feature can be ported to D8. That is why I took it out. Once we know what happens to the context module in D8 we can move forward.

I personally hate features that are not upgradable. That is my main concern. I do not leave people standing in the rain with impossible upgrades.

DRM7000’s picture

DRM7000 CreditAttribution: DRM7000 commented

I'm new to Drupal and not a developer. Can I confirm, does GA module for Drupal support Content Grouping at present?

Kristi Wachter’s picture

Kristi Wachter CreditAttribution: Kristi Wachter as a volunteer commented

It looks like Context has a beta release for Drupal 8 - would it make sense to resurrect this patch and feature set?

rovo’s picture

rovo
Location Delaware
CreditAttribution: rovo as a volunteer commented

I'm currently utilizing Custom Definitions -> Custom Dimensions to achieve a similar analyses of content types, but seems like Content Grouping would be more robust.

japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry at Acquia commented
Status: Needs work » Closed (outdated)