Fix entity delete link Views field handlers to use delete access check [#2114081]

Hi, we check if have access to update rather than to delete.

    if (!commerce_customer_profile_access('update', $profile)) {

Regards!

Comment	File	Size	Author
	Fix_commerce_customer_handler_field_customer_profile_link_delete-Commerce_Customer.patch	850 bytes	facine

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

facine CreditAttribution: facine commented 17 October 2013 at 11:57

Status:

Active

» Needs review

Update status!

Comment #2

rszrama CreditAttribution: rszrama commented 11 November 2013 at 21:00

Title:	Fix customer profile link delete field handler	» Fix entity delete link Views field handlers to use delete access check
Category:	Bug report	» Task
Priority:	Major	» Normal
Issue summary:	View changes
Status:	Needs review	» Needs work

I'm going to update the access checks in all of our delete link Views field handlers, but from a functionality standpoint, there actually is no bug here. The function that ultimately gets called treats "edit" and "delete" the same, since we don't separate out delete permission from update permission. For that matter, it would've worked fine if the access check was for "carrot", which is pretty silly. Fortunately, I just updated an old issue to become a feature request to resolve this in 2.x. ; )