I have a page with two quicktabs. I edit the quicktab settings and make the second tab: Default tab.
This does not work. I have to set is as the first tab and then make it default for it to work.
As soon as I try to make the second tab default tab, it just doesn't work. Anyone?
| Comment | File | Size | Author |
|---|---|---|---|
| #18 | quicktabs-default-tab-doesnt-work-2112069-18-D7.patch | 602 bytes | bhavikshah9 |
Comments
Comment #1
bhavikshah9 commentedI am using 'quicktabs-7.x-3.6'. I have noticed that the default tab setting is not working only for 'ui_tabs' Renderer. When you select any other renderer, default tab setting is working perfectly.
Anyone else having same issue? Does anyone have patch for this?
Comment #2
bhavikshah9 commentedI have worked on resolving this issue. I have tested and its working fine now. Please review attached patch.
Comment #3
bhavikshah9 commentedComment #4
cilefen commented@bhavikshah9 As discussed on IRC, this is your first patch contribution. That is great news and I hope you continue.
Having looked at this patch as such, there are a few things you need to do differently.
First, the file you uploaded is a raw file, not a patch. Follow these instructions to create a patch: Making a Drupal patch with Git.
Second, you must make sure you code follows the JavaScript coding standards. PHP code must follow the Coding standards.
You can use the Coder module to scan your code for compliance.
Comment #5
ultimateboy commentedSee #4. This is not a properly formatted patch.
Comment #6
bhavikshah9 commentedWith all due respect to @cilefen and @ultimateboy, I have submitted new patch file here.
Thanks a lot @cilefen and @ultimateboy. I have tried to follow the standards this time.
I would like to request you to let me know if still there is some problem with this patch. I will surely take necessary efforts to correct it and submit a fresh patch again.
Comment #7
bhavikshah9 commentedComment #9
cilefen commentedNormally, you would not rename the file in that patch unless that is the intent of the issue. This may be why the patch did not apply. Be sure you create the patch against the development branch, which in this case is 7.x-3.x.
The Drupal coding standards specifies spaces, two spaces, not tabs.
Comment #10
bhavikshah9 commentedTrying one more time.
Heartily thanks to @cilefen for continuous help.
Comment #11
bhavikshah9 commentedComment #12
cilefen commentedThis patch does not apply to the 7.x-3.x branch. I recommend reading Making a Drupal Patch.
Comment #13
bhavikshah9 commentedAfter @cilefen cleared few doubts, I have created new patch for this.
Comment #14
bhavikshah9 commented@cilefen, One last time for the day. Can you please... check it?
Comment #18
bhavikshah9 commentedHere is the patch that resolves the issue.
Comment #19
bhavikshah9 commentedComment #20
bhavikshah9 commentedCan someone RTBC this?
Comment #21
samvel commentedNot working for me, because there is should be active option instead of selected:
https://api.jqueryui.com/tabs/#option-active
Comment #22
bhavikshah9 commented@Samvel: Thanks for your feedback. But, I have tested the patch on simplytest.me. And its working fine for me. Can you please let me know little more details, why its not working for you? May be, you can test the patch on simplytest.me.
Or you want it to be replaced to adhere to the link you have posted?
Comment #23
pallavi_sugandhi commentedI already applied the patch for this related issue please refer this link https://www.drupal.org/node/1570762
Comment #24
samvel commented@bhavikshah9, pallavi_sugandhi answered in https://www.drupal.org/node/1570762 and i found other problem with this patch. After applying this patch access to any tab by direct url (with hash in URL) not work anymore.
Comment #25
samvel commentedFor me i see temporary solution:
May be not temporary :)
Comment #26
smustgrave commentedWith D7 EOL approaching in a month I'm starting to triage the D7 side of quicktabs queue.
If still an issue or needed for 4.0.x (latest branch) feel free to reopen