ugly button

CommentFileSizeAuthor
#2 Screen Shot 2013-10-18 at 21.36.25.png100.21 KBemma.maria
#2 Screen Shot 2013-10-18 at 21.36.17.png41.89 KBemma.maria
#2 primary-buttons-updatephp-2110305-2.patch991 bytesemma.maria
02.jpeg74.93 KBnod_
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

emma.maria’s picture

emma.maria
she/her
CreditAttribution: emma.maria commented
Assigned: Unassigned » emma.maria
emma.maria’s picture

emma.maria
she/her
CreditAttribution: emma.maria commented
FileSize
primary-buttons-updatephp-2110305-2.patch991 bytes
Screen Shot 2013-10-18 at 21.36.17.png41.89 KB
Screen Shot 2013-10-18 at 21.36.25.png100.21 KB

I have added the primary button classes to the buttons in update.php.

Continue button

Apply pending updates button

emma.maria’s picture

emma.maria
she/her
CreditAttribution: emma.maria commented
Status: Active » Needs review
emma.maria’s picture

emma.maria
she/her
CreditAttribution: emma.maria commented
Assigned: emma.maria » Unassigned
nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Needs review » Reviewed & tested by the community

Nice! thanks :)

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Issue tags: -styleguide

#2: primary-buttons-updatephp-2110305-2.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, primary-buttons-updatephp-2110305-2.patch, failed testing.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs work » Needs review
Issue tags: +styleguide

#2: primary-buttons-updatephp-2110305-2.patch queued for re-testing.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs review » Reviewed & tested by the community

bot fluke I presume

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

Commit 99b9a851f5a6414f9c4594478e441c88ff904d28 for D8 says it fixes this issue, but it's for another one.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

2: primary-buttons-updatephp-2110305-2.patch queued for re-testing.

yannickoo’s picture

yannickoo
Location Berlin
CreditAttribution: yannickoo commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

This was really fixed with 99b9a85 :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.