When running a git action on a site which is not actually under git control Git would lookup the tree and happily perform the action on the platform instead if that were a git repo.

This is an addition to: #2104677: Listen to repo_path option

CommentFileSizeAuthor
#5 provision_git.code_.2104777-5.patch8.55 KBhelmo
#3 provision_git.code_.2104777-2.patch768 byteshelmo
#1 provision_git.code_.2104777-1.patch2.98 KBhelmo

Comments

helmo’s picture

helmo commented
StatusFileSize
new provision_git.code_.2104777-1.patch2.98 KB

Here's the patch ... commit 9c6660cffdf5733fb530da798e30d51bef67bab0 in my sandbox.

helmo’s picture

helmo commented
Status: Active » Needs review

The hosting_site_git issue: #2104703: Limit scope to pull site not platform

helmo’s picture

helmo commented
StatusFileSize
new provision_git.code_.2104777-2.patch768 bytes

One extra commit in my sandbox to work with symlinks: 0a13fef822d86ed950959331cb60468a4d41551c

jon pugh’s picture

jon pugh
he/him
Primary language English
Location Newburgh, NY
commented
Status: Needs review » Needs work

This looks great but does not apply now that I've committed your other patches.

Can we get a re-roll?

thanks!

helmo’s picture

helmo commented
Status: Needs work » Needs review
StatusFileSize
new provision_git.code_.2104777-5.patch8.55 KB

Some more clean up had build up in the 6.x-2.x branch of my sandbox...
Here's a full diff between your 6.x-1.x and my 6.x-2.x

jon pugh’s picture

jon pugh
he/him
Primary language English
Location Newburgh, NY
commented
Status: Needs review » Closed (fixed)

Applied and committed your 2.x branch. Thanks for the cleanups, and the feature!

jon pugh’s picture

jon pugh
he/him
Primary language English
Location Newburgh, NY
commented

Created our first BETA release based on this. Want to help flesh out the new README?

helmo’s picture

helmo commented
Status: Closed (fixed) » Fixed

Yay ... Added #2122869: Create README.txt

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

  • Commit 9c6660c on 6.x-1.x, 7.x-1.x by helmo: 
    Issue #2104777 by helmo: Add force_repo_path_as_toplevel option.
  • Commit 0a13fef on 6.x-1.x, 7.x-1.x by helmo:
    Issue #2104777 by helmo: Use realpath in force_repo_path_as_toplevel...
  • Commit 3fe05d5 on 6.x-1.x, 7.x-1.x authored by helmo, committed by Jon Pugh:
    Issue #2104777 by helmo: Added force_repo_path_as_toplevel() option,...

  • Commit 9c6660c on 6.x-1.x, 7.x-1.x, 7.x-3.x by helmo: 
    Issue #2104777 by helmo: Add force_repo_path_as_toplevel option.
  • Commit 0a13fef on 6.x-1.x, 7.x-1.x, 7.x-3.x by helmo:
    Issue #2104777 by helmo: Use realpath in force_repo_path_as_toplevel...
  • Commit 3fe05d5 on 6.x-1.x, 7.x-1.x, 7.x-3.x authored by helmo, committed by Jon Pugh:
    Issue #2104777 by helmo: Added force_repo_path_as_toplevel() option,...