Provide machine_name option for to node type display.

CommentFileSizeAuthor
#3 views-2085079-3.patch581 bytessilvi.addweb
#1 views.documentation.2085079-1.patch572 bytesElijah Lynn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Elijah Lynn’s picture

Elijah Lynn
Location Portland, Oregon
CreditAttribution: Elijah Lynn commented
FileSize
views.documentation.2085079-1.patch572 bytes
Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented
Version: 7.x-3.7 » 7.x-3.x-dev
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +Needs reroll

The 5 year old patch to views_handler_field_node_type.inc does not apply to the latest views 7.x-3.x-dev and if still applicable needs a reroll.

Checking patch modules/node/views_handler_field_node_type.inc...
error: while searching for:
  }

  /**
   * Provide machine_name option for to node type display.
   */
  function options_form(&$form, &$form_state) {
    parent::options_form($form, $form_state);

error: patch failed: modules/node/views_handler_field_node_type.inc:19
error: modules/node/views_handler_field_node_type.inc: patch does not apply
silvi.addweb’s picture

silvi.addweb CreditAttribution: silvi.addweb at AddWeb Solution Pvt. Ltd. commented
Status: Needs work » Needs review
FileSize
views-2085079-3.patch581 bytes

@Chris2, Please review my attached patch, I updated it for views 7.x-3.x-dev. Thanks!...

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Issue tags: -Needs reroll
renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented
Status: Needs review » Reviewed & tested by the community

Yeah, I've applied #3 and it really makes sense and it's valid so moving it to RTBC. Thank you so much @elijah-lynn, good catch!

  • RenatoG committed 5b7ca2a on 7.x-3.x authored by Elijah Lynn 
    Issue #2085079 by Elijah Lynn, dev16.addweb, Chris Matthews,...
renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented
Status: Reviewed & tested by the community » Fixed
Parent issue: » #3118500: Plan for Views 7.x-3.25

Moved to the dev branch. Thank everyone for your contribution

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.